Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#360] Show that repos is Forked if Repositories #367

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

[#360] Show that repos is Forked if Repositories #367

wants to merge 3 commits into from

Conversation

RubanovDmitriy
Copy link
Contributor

@RubanovDmitriy
issue 360
e53751f 
* Added filter for oranization.name in repositories_list.html
@RubanovDmitriy RubanovDmitriy mentioned this pull request Nov 19, 2023
Open
fey
fey reviewed Nov 20, 2023
View reviewed changes
templates/components/tables/repositories_list.html Outdated
<a href="{{ repository.get_absolute_url }}">
{{ repository.name }}
</a>
{% elif repository.organization.name != 'Hexlet' %}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

вот эта штука не должна решаться на фронте. Ведь есть репозитории, которые форкнули в Хекслете, а есть проекты-оригиналы для тех. Посмотрите, что может отдавать гитхаб. Врое бы там есть атрибут, который говорит .что репозиторий - форк.

@RubanovDmitriy
issue 360
56012c4 
* Added bool field "fork" to Repository model
* Added saving this field to update_or_create_record
* Added check for fork in repositories_list template
@RubanovDmitriy
issue 360
89478af 
* Added bool field "fork" to Repository model
* Added saving this field to update_or_create_record
* Added check for fork in repositories_list template
@fey
Copy link
Collaborator

fey commented Nov 21, 2023

Можете подключить еще парочку репозиториев? Можно например

@fey
Copy link
Collaborator

fey commented Nov 21, 2023

https://github.com/fey/typescript-developer-project-81
https://github.com/fey/awesome-russian-it

fey
fey reviewed Nov 21, 2023
View reviewed changes
contributors/migrations/0014_repository_fork.py
operations = [
migrations.AddField(
model_name="repository",
name="fork",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

тк это булево значение, давайте его так и назовем is_fork и дальше ниже по коду.

@fey fey marked this pull request as draft November 27, 2023 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fey fey fey left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RubanovDmitriy @fey