-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#153] add footer (internationalized) #161
Draft
RedGradient
wants to merge
43
commits into
Hexlet:main
Choose a base branch
from
RedGradient:add-footer
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+1,209
−944
Draft
Changes from 5 commits
Commits
Show all changes
43 commits
Select commit
Hold shift + click to select a range
21cba49
add footer
af37166
fix 'Not Found' error when adding user to wks
c1d9992
add tool versions for asdf
fey f479d43
fix widget script
fey 087ca3d
Merge pull request #164 from fey/fix-widget-form
fey a5132e3
Merge pull request #163 from RedGradient/fix-redirect-after-adding-user
Malcom1986 f48ef44
add dockerfile
e583e35
fix
b152990
fix dockerfile
a9d323e
add cors configuration
ab8374a
fix typo path in script
b59b9ad
Merge pull request #169 from Hexlet/cors-1
fey 9f65100
add Thymeleaf Layout dialect dependency
3a29ccf
rename: header.html -> head.html
c15f424
make templating with layouts
37ffe12
rename: head.html -> header.html
793e90b
Create requirements.yml
Salivya 4205518
Update requirements.yml
Salivya 1ef4a32
Update requirements.yml по комментариям пользователя fey
Salivya c861461
Merge pull request #171 from Salivya/Salivya-patch-1
fey c5c91a4
Update widget code
fey 5574b45
remove requirements.yml to docs
AavadaKedavra 60670c3
Issue179 - Удаление пользователя из воркспейса
AlekseyNechunaev ced7e2a
Issue179 - Убрал обращение к репозиторию из контроллера
AlekseyNechunaev 814efa2
Issue165 - Убрал лишнее
AlekseyNechunaev 359dee0
Merge pull request #182 from AavadaKedavra/444_add_test_cases
fey 1cb4813
Issue179 - Правки по ревью, переместил кнопку удаления в таблицу
AlekseyNechunaev e494cea
Issue179 - Правки по ревью, изменил стиль кнопки удаления, добавил мо…
AlekseyNechunaev a76e651
move out styles from html to separate css file
d8960f3
[#181] fix workspace cards height
asenka0301 c0a4737
Merge pull request #183 from AlekseyNechunaev/feature/nechunaev/Issue179
Malcom1986 c71929b
use bootstrap classes instead of custom css properties
585f48f
Merge pull request #186 from asenka0301/frontend/fix-workspace-cards-…
fey b5e0b63
make templating with layouts
11fc6d7
add footer
3f07e5b
add Thymeleaf Layout dialect dependency
09c8c0d
rename: header.html -> head.html
0c5ef95
make templating with layouts
45ac594
rename: head.html -> header.html
57951cf
move out styles from html to separate css file
70ceb12
use bootstrap classes instead of custom css properties
668d6d7
make templating with layouts
e930cdb
Merge remote-tracking branch 'origin/add-footer' into add-footer
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -37,5 +37,6 @@ | |
</div> | ||
</div> | ||
</main> | ||
<footer th:replace="~{fragments/footer :: mainFooter}"></footer> | ||
</body> | ||
</html> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -48,5 +48,6 @@ | |
</div> | ||
</div> | ||
</main> | ||
<footer th:replace="~{fragments/footer :: mainFooter}"></footer> | ||
</body> | ||
</html> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -84,6 +84,6 @@ | |
</div> | ||
</div> | ||
</main> | ||
|
||
<footer th:replace="~{fragments/footer :: mainFooter}"></footer> | ||
</body> | ||
</html> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,13 @@ | ||
<!doctype html> | ||
<html lang="en" | ||
xmlns:th="http://www.thymeleaf.org" | ||
xmlns:layout="http://www.ultraq.net.nz/thymeleaf/layout"> | ||
<head th:replace="~{fragments/header :: head}"></head> | ||
<body> | ||
<nav th:replace="~{fragments/panels :: mainNavbarTop}"></nav> | ||
|
||
<main layout:fragment="content"></main> | ||
|
||
<footer th:replace="~{fragments/footer :: mainFooter}"></footer> | ||
</body> | ||
</html> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,39 +1,40 @@ | ||
<!DOCTYPE html> | ||
<html lang="en" xmlns:th="http://www.thymeleaf.org"> | ||
<head th:replace="~{fragments/header :: head}"></head> | ||
<body style="padding-top: 4.5rem"> | ||
<nav th:replace="~{fragments/panels :: mainNavbarTop}"></nav> | ||
<main class="container"> | ||
<div class="row"> | ||
<div class="col"> | ||
<form method="post" th:action="@{/workspace}" th:object="${createWorkspace}"> | ||
<div class="form-floating mb-3"> | ||
<input class="form-control" id="inputWksUrl" placeholder="p" | ||
th:classappend="${!#fields.hasErrors('url') && formModified ? 'is-valid' : ''}" | ||
th:errorclass="is-invalid" th:field="*{url}" | ||
type="url"> | ||
<label for="inputWksUrl" th:text="#{wks.placeholder.url}"></label> | ||
<div class="invalid-feedback" th:each="err : ${#fields.errors('url')}" th:text="${err}"></div> | ||
</div> | ||
<div class="form-floating mb-3"> | ||
<input class="form-control" id="inputWksName" placeholder="p" | ||
th:classappend="${!#fields.hasErrors('name') && formModified ? 'is-valid' : ''}" | ||
th:errorclass="is-invalid" th:field="*{name}" | ||
type="text"> | ||
<label for="inputWksName" th:text="#{wks.placeholder.name}"></label> | ||
<div class="invalid-feedback" th:each="err : ${#fields.errors('name')}" th:text="${err}"></div> | ||
</div> | ||
<div class="form-floating mb-3"> | ||
<textarea class="form-control" id="inWksDesc" placeholder="p" style="height: 100px" | ||
th:errorclass="is-invalid" th:field="*{description}"></textarea> | ||
<label for="inWksDesc" th:text="#{wks.placeholder.descr}"></label> | ||
<div class="invalid-feedback" th:each="err : ${#fields.errors('description')}" | ||
th:text="${err}"></div> | ||
</div> | ||
<button class="btn btn-primary" type="submit" th:text="#{btn.create}"></button> | ||
</form> | ||
<html lang="en" | ||
xmlns:th="http://www.thymeleaf.org" | ||
xmlns:layout="http://www.ultraq.net.nz/thymeleaf/layout" | ||
layout:decorate="application.html"> | ||
|
||
<main layout:fragment="content" class="container"> | ||
<div class="row"> | ||
<div class="col"> | ||
<form method="post" th:action="@{/workspace}" th:object="${createWorkspace}"> | ||
<div class="form-floating mb-3"> | ||
<input class="form-control" id="inputWksUrl" placeholder="p" | ||
th:classappend="${!#fields.hasErrors('url') && formModified ? 'is-valid' : ''}" | ||
th:errorclass="is-invalid" th:field="*{url}" | ||
type="url"> | ||
<label for="inputWksUrl" th:text="#{wks.placeholder.url}"></label> | ||
<div class="invalid-feedback" th:each="err : ${#fields.errors('url')}" th:text="${err}"></div> | ||
</div> | ||
<div class="form-floating mb-3"> | ||
<input class="form-control" id="inputWksName" placeholder="p" | ||
th:classappend="${!#fields.hasErrors('name') && formModified ? 'is-valid' : ''}" | ||
th:errorclass="is-invalid" th:field="*{name}" | ||
type="text"> | ||
<label for="inputWksName" th:text="#{wks.placeholder.name}"></label> | ||
<div class="invalid-feedback" th:each="err : ${#fields.errors('name')}" th:text="${err}"></div> | ||
</div> | ||
<div class="form-floating mb-3"> | ||
<textarea class="form-control" id="inWksDesc" placeholder="p" style="height: 100px" | ||
th:errorclass="is-invalid" th:field="*{description}"></textarea> | ||
<label for="inWksDesc" th:text="#{wks.placeholder.descr}"></label> | ||
<div class="invalid-feedback" th:each="err : ${#fields.errors('description')}" | ||
th:text="${err}"></div> | ||
</div> | ||
<button class="btn btn-primary" type="submit" th:text="#{btn.create}"></button> | ||
</form> | ||
</div> | ||
</div> | ||
</div> | ||
</main> | ||
</body> | ||
</main> | ||
|
||
</html> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,92 @@ | ||
<!DOCTYPE html> | ||
<html lang="en" xmlns:th="http://www.thymeleaf.org"> | ||
<body> | ||
<footer class="d-flex p-3 bg-dark text-light" th:fragment="mainFooter"> | ||
<div class="container-xl"> | ||
<div class="row justify-content-lg-around"> | ||
<div class="col-sm-6 col-md-3 col-lg-auto"> | ||
<a class="text-dark px-0 py-0 text-decoration-none " href="https://ru.hexlet.io"> | ||
<p class="h3 mb-2 text-light">© Hexlet</p> | ||
</a> | ||
<ul class="nav flex-column"> | ||
<li class="nav-item"> | ||
<a class="nav-link px-0 py-1 text-light" | ||
href="https://sicp.hexlet.io/ru/pages/about" th:text="#{about}"></a> | ||
</li> | ||
<li class="nav-item"> | ||
<a class="nav-link px-0 py-1 text-light" href="https://github.com/Hexlet/hexlet-correction" | ||
target="_blank" | ||
th:text="#{source-code}"></a> | ||
</li> | ||
<li class="nav-item"> | ||
<a class="nav-link px-0 py-1 text-light" href="https://t.me/hexletcommunity/12" | ||
target="_blank" | ||
th:text="#{telegram}"></a> | ||
</li> | ||
</ul> | ||
</div> | ||
<div class="col-sm-6 col-md-3 col-lg-auto"> | ||
<p class="h5 mb-3" th:text="#{help}"></p> | ||
<ul class="nav flex-column"> | ||
<li class="nav-item"> | ||
<a class="nav-link px-0 py-1 text-light" | ||
href="https://ru.hexlet.io/blog" | ||
th:text="#{blog}"></a> | ||
</li> | ||
<li class="nav-item"> | ||
<a class="nav-link px-0 py-1 text-light" | ||
href="https://ru.hexlet.io/knowledge" | ||
th:text="#{knowledge-base}"></a> | ||
</li> | ||
<li class="nav-item"> | ||
<a class="nav-link px-0 py-1 text-light" | ||
href="https://ru.hexlet.io/pages/recommended-books" | ||
th:text="#{recommended-books}"></a> | ||
</li> | ||
</ul> | ||
</div> | ||
<div class="col-sm-6 col-md-3 col-lg-auto"> | ||
<p class="h5 mb-3" th:text="#{other-opensource-projects}"></p> | ||
<ul class="nav flex-column"> | ||
<li class="nav-item"> | ||
<a class="nav-link px-0 py-1 text-light" | ||
href="https://github.com/Hexlet/hexlet-cv" | ||
th:text="#{hexlet.cv}"></a> | ||
</li> | ||
<li class="nav-item"> | ||
<a class="nav-link px-0 py-1 text-light" | ||
href="https://github.com/Hexlet/hexlet-editor" | ||
th:text="#{hexlet.editor}"></a> | ||
</li> | ||
<li class="nav-item"> | ||
<a class="nav-link px-0 py-1 text-light" | ||
href="https://github.com/Hexlet/hexlet-friends" | ||
th:text="#{hexlet.friends}"></a> | ||
</li> | ||
</ul> | ||
</div> | ||
<div class="col-sm-6 col-md-3 col-lg-auto"> | ||
<p class="h5 mb-3" th:text="#{miscellaneous}"></p> | ||
<ul class="nav flex-column"> | ||
<li class="nav-item"> | ||
<a class="nav-link px-0 py-1 text-light" | ||
href="https://ru.code-basics.com/" | ||
th:text="#{code-basics}"></a> | ||
</li> | ||
<li class="nav-item"> | ||
<a class="nav-link px-0 py-1 text-light" | ||
href="https://codebattle.hexlet.io/" | ||
th:text="#{codebattle}"></a> | ||
</li> | ||
<li class="nav-item"> | ||
<a class="nav-link px-0 py-1 text-light" | ||
href="https://guides.hexlet.io/" | ||
th:text="#{hexlet.editor}"></a> | ||
</li> | ||
</ul> | ||
</div> | ||
</div> | ||
</div> | ||
</footer> | ||
</body> | ||
</html> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Для чего используется этот стиль?
Мы не используем кастомные стили - обходимся тем, что дает нам Bootstrap
Плюс в таком виде добавляется пустое пространство над хедером.