fix assignment path with kz locale #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
corsicanec82
requested changes
Dec 21, 2023
src/utils/assignments.js
Outdated
| @@ -36,7 +36,8 @@ const getLessonData = (lessonUrl) => { | |||
| }; | |||
|
|
|||
| const generateAssignmentPath = (repoPath, courseSlug, lessonSlug, locale) => { | |||
| const courseSlugWithLocale = locale === 'en' ? courseSlug : `${courseSlug}-${locale}`; | |||
| const normalizedLocale = locale === 'kz' ? 'ru' : locale; | |||
| const courseSlugWithLocale = locale === 'en' ? courseSlug : `${courseSlug}-${normalizedLocale}`; | |||
There was a problem hiding this comment.
locale === 'en' так а тут уже по идее надо использовать локаль полученную на предыдущем шаге normalizedLocale
src/utils/assignments.js
Outdated
| @@ -36,7 +36,8 @@ const getLessonData = (lessonUrl) => { | |||
| }; | |||
|
|
|||
| const generateAssignmentPath = (repoPath, courseSlug, lessonSlug, locale) => { | |||
| const courseSlugWithLocale = locale === 'en' ? courseSlug : `${courseSlug}-${locale}`; | |||
| const normalizedLocale = locale === 'kz' ? 'ru' : locale; | |||
There was a problem hiding this comment.
давай просто определим константу на уровне модуля - объект с маппингом локалей на языки
const contentLocales = {
ru: 'ru',
kz: 'ru',
en: 'en',
es: 'es',
};
и будем юзать там где нужно
contentLocales[locale]
| @@ -11,11 +11,11 @@ const assignmentResetCmd = require('../../src/commands/assignment/reset.js'); | |||
| const { initSettings } = require('../../src/config.js'); | |||
| const { readDirP, getFixturePath, getAssignmentConfig } = require('../helpers/index.js'); | |||
|
|
|||
| const buildLessonUrl = (courseSlug, lessonSlug) => ( | |||
| `https://ru.hexlet.io/courses/${courseSlug}/lessons/${lessonSlug}/theory_unit` | |||
| const buildLessonUrl = (locale, courseSlug, lessonSlug) => ( | |||
There was a problem hiding this comment.
кажется что проще добавить локаль третим параметром с дефолтным значением ru
И тогда достаточно будет поставить только там где кастом - kz
added 2 commits
December 21, 2023 15:13
corsicanec82
approved these changes
Dec 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.