Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement][Link Utilities] Custom link profiles - Run "Remove diacritics" before "Remove special chars" #119

Open
Boof-Woof opened this issue Oct 10, 2024 · 1 comment
Assignees
Labels
enhancement New feature or request Link Utilities issues related to Link Utilities

Comments

@Boof-Woof
Copy link

Boof-Woof commented Oct 10, 2024

Is your feature request related to a problem? Please describe.
Currently, there is no way to use "Remove diacritics" at the same time as "Remove special chars" without it removing the diacritics entirely rather than converting.

Describe the solution you'd like
I would like "Remove diacritics" to be run before "Remove special chars" so that the diacritics are converted rather than removed.

Describe alternatives you've considered

  1. Adding a new formatting checkbox for removing colons.
  2. Comma-separated text field to list specific characters to be removed.
  3. Regex formatting text field.

Additional context
In my pursuit of converting diacritics and removing a colon from a game's name, it ends up removing both the colon AND the diacritics entirely rather than converting. See the below example:


Original Game Name: Pokémon Yellow Version: Special Pikachu Edition
Formatting Options:

  • "Remove specials chars"
  • "Remove diacritics"
  • "Whitespaces to hyphens"
  • "To lowercase"

Expected Result: pokemon-yellow-version-special-pikachu-edition
Actual Result: pokmon-yellow-version-special-pikachu-edition

@Boof-Woof Boof-Woof added the enhancement New feature or request label Oct 10, 2024
@HerrKnarz
Copy link
Owner

Sorry for the late reply!

Hmm, yeah, I can add the option switch those actions for the link profiles. It shouldn't be hard coded, though, because some websites really just remove special chars (so "Trüberbrook" needs to become "Trberbrook" and not "Truberbrook". I haven't had a case, where both diacritics and special chars had to be removed at the same time, though. But game name with both cases aren't that common, I guess.

Can you please tell me the website do you want to add and how you configured it, so I can use that to test the implementation?

Adding a regex formatting option also is a good idea, btw. I'll add that, too!

@HerrKnarz HerrKnarz added the Link Utilities issues related to Link Utilities label Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Link Utilities issues related to Link Utilities
Projects
None yet
Development

No branches or pull requests

2 participants