From 2ef226e94d40ec3ac2655e48dc61ff294a26b02c Mon Sep 17 00:00:00 2001
From: "Guilherme G. Menaldo" <guilherme.menaldo@outlook.com>
Date: Fri, 27 Oct 2023 19:44:23 -0300
Subject: [PATCH] update CI to use classic spell list for older clients

old clients can't properly load the main autospell db for RE, using the
herc-provided fallback makes them pass.
---
 .github/workflows/clang15_test.yml | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/.github/workflows/clang15_test.yml b/.github/workflows/clang15_test.yml
index f1386c171ac..ba7bc037f3e 100644
--- a/.github/workflows/clang15_test.yml
+++ b/.github/workflows/clang15_test.yml
@@ -21,7 +21,10 @@ jobs:
         HTTPLIB: ["", "--with-http_parser=llhttp"]
         SANITIZER: ["--disable-manager", "--disable-manager --enable-sanitize=full"]
         PACKET_VERSION: ["--enable-packetver=20221024", "--enable-packetver=20130724"]
-        include: # Use "CLASSIC_AUTOSPELL_LIST" for 20130724 RE or we will get warnings due to the list being too small
+        include:
+          # Empty CLASSIC_AUTOSPELL_LIST for every other flow
+          - CLASSIC_AUTOSPELL_LIST: ""
+          # Use "-DCLASSIC_AUTOSPELL_LIST" for 20130724 RE or we will get warnings due to the list being too small
           - PACKET_VERSION: "--enable-packetver=20130724"
             RENEWAL: ""
             CLASSIC_AUTOSPELL_LIST: "-DCLASSIC_AUTOSPELL_LIST"
@@ -56,8 +59,7 @@ jobs:
       INSTALL_PACKAGES: ${{ matrix.CC }} mariadb-client libmariadbclient-dev-compat
       SQLHOST: mariadb
       CC: ${{ matrix.CC }}
-      CPPFLAGS: ${{ (matrix.CLASSIC_AUTOSPELL_LIST != '' &&  matrix.CLASSIC_AUTOSPELL_LIST) || '' }}
-      CONFIGURE_FLAGS: CC=${{ matrix.CC }} --enable-debug --enable-Werror --enable-buildbot ${{ matrix.RENEWAL }} ${{ matrix.HTTPLIB }} ${{ matrix.CLIENT_TYPE }} ${{ matrix.SANITIZER }} ${{ matrix.PACKET_VERSION }} CPPFLAGS="${{ env.CPPFLAGS }}"
+      CONFIGURE_FLAGS: ${{ format('CC={0} --enable-debug --enable-Werror --enable-buildbot {1} {2} {3} {4} {5} CPPFLAGS={6}', matrix.CC,  matrix.RENEWAL, matrix.HTTPLIB, matrix.CLIENT_TYPE, matrix.SANITIZER, matrix.PACKET_VERSION, matrix.CLASSIC_AUTOSPELL_LIST) }}
       PACKET_VERSION: ${{ matrix.PACKET_VERSION }}
     steps:
       - uses: actions/checkout@v1