Remove any type from struct in IOExample and Trace #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #17 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 1 1
Lines 14 14
=========================================
Hits 14 14 ☔ View full report in Codecov by Sentry. |
This was
linked to
issues
Nov 14, 2024
- Vector -> AbstractVector - Remove extraneous type parameters for IOExample and Trace
ReubenJ
approved these changes
Nov 14, 2024
ReubenJ
added a commit
that referenced
this pull request
Nov 15, 2024
THinnerichs
added a commit
that referenced
this pull request
Nov 15, 2024
`v0.2`: Breaking changes introduced in #17 by adding type parameters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Having
Anytype in a struct is not good for performance because the Julia compiler will use indirection instead of holding the data directly. By declaring the input and output types in the struct, we avoid the use ofAny.