Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test coverage #64

Merged
merged 3 commits into from
Mar 4, 2024
Merged

Add test coverage #64

merged 3 commits into from
Mar 4, 2024

Conversation

ReubenJ
Copy link
Member

@ReubenJ ReubenJ commented Mar 1, 2024

Closes #63

@ReubenJ ReubenJ self-assigned this Mar 1, 2024
@ReubenJ ReubenJ added the enhancement New feature or request label Mar 1, 2024
@ReubenJ ReubenJ force-pushed the CI/report-coverage branch from 666af10 to 572b81a Compare March 1, 2024 10:00
@ReubenJ ReubenJ changed the base branch from master to dev March 1, 2024 10:00
Copy link

codecov bot commented Mar 1, 2024

Welcome to Codecov 🎉

Once merged to your default branch, Codecov will compare your coverage reports and display the results in this comment.

Thanks for integrating Codecov - We've got you covered ☂️

@ReubenJ ReubenJ force-pushed the CI/report-coverage branch from a9a0647 to 7a8cc81 Compare March 1, 2024 10:23
@ReubenJ ReubenJ marked this pull request as ready for review March 1, 2024 10:24
@ReubenJ ReubenJ requested a review from THinnerichs March 1, 2024 10:24
@ReubenJ ReubenJ linked an issue Mar 1, 2024 that may be closed by this pull request
4 tasks
@THinnerichs
Copy link
Member

Which Julia versions do we want to test for? Shouldn't nightly already include 1.10?

@ReubenJ
Copy link
Member Author

ReubenJ commented Mar 4, 2024

Nightly is the current state of the master branch, I believe. It's possible that something is broken in nightly that is working in 1.10 just because a new (broken) feature has been merged to master, or something like that.

I think we should be testing 1.8 and 1.10 at least since we say we support >1.8, and 1.10 is the latest stable release. If we want to be more thorough about it, we should test 1.9 and nightly, too, but either/both of those are probably overkill for now.

@THinnerichs
Copy link
Member

Then we should rather do

version:
          - '1.8'
          - '1'
          - 'nightly'

which will automatically expand to the latest stable release.

.github/workflows/CI.yml Outdated Show resolved Hide resolved
@ReubenJ

This comment was marked as resolved.

@ReubenJ ReubenJ requested a review from THinnerichs March 4, 2024 12:21
@THinnerichs THinnerichs merged commit e08f886 into dev Mar 4, 2024
5 checks passed
@THinnerichs THinnerichs deleted the CI/report-coverage branch March 4, 2024 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add testing coverage
2 participants