-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add test coverage #64
Conversation
666af10
to
572b81a
Compare
Welcome to Codecov 🎉Once merged to your default branch, Codecov will compare your coverage reports and display the results in this comment. Thanks for integrating Codecov - We've got you covered ☂️ |
a9a0647
to
7a8cc81
Compare
Which Julia versions do we want to test for? Shouldn't |
Nightly is the current state of the master branch, I believe. It's possible that something is broken in nightly that is working in 1.10 just because a new (broken) feature has been merged to master, or something like that. I think we should be testing 1.8 and 1.10 at least since we say we support >1.8, and 1.10 is the latest stable release. If we want to be more thorough about it, we should test 1.9 and nightly, too, but either/both of those are probably overkill for now. |
Then we should rather do
which will automatically expand to the latest stable release. |
This comment was marked as resolved.
This comment was marked as resolved.
Co-authored-by: Tilman Hinnerichs <[email protected]>
Closes #63