Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor synth #56

Closed
THinnerichs opened this issue Jan 19, 2024 · 3 comments
Closed

Refactor synth #56

THinnerichs opened this issue Jan 19, 2024 · 3 comments

Comments

@THinnerichs
Copy link
Member

  • introduce eval(...) to take care of the different interpretation outputs of HerbInterpret.interpret(...)
  • introduce stop_criterium(...) defining when to stop the search
@ReubenJ
Copy link
Member

ReubenJ commented Mar 14, 2024

@THinnerichs can we close now that #70 is published?

@THinnerichs
Copy link
Member Author

THinnerichs commented Mar 19, 2024

  1. evaluate(...) should be able to take different kinds of problem specification. This is definitely for later.
  2. stop_criterium is still open.

We have

 score = evaluate(problem, expr, symboltable, shortcircuit=shortcircuit, allow_evaluation_errors=allow_evaluation_errors)
if score == 1
    return (candidate_program, optimal_program)
elseif score >= best_score
    best_score = score
    best_program = candidate_program
end

but we may want to stop using other criteria than score == 1.

@THinnerichs
Copy link
Member Author

Resolved recently.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants