Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the search start from the best reward position #106

Merged
merged 6 commits into from
May 24, 2024

Conversation

nicolaefilat
Copy link
Contributor

@nicolaefilat nicolaefilat commented May 21, 2024

Changes I made:

  • Add select that selects top 5 best programs in terms of reward
  • Add update_grammar for traces that is not used yet. It updates based on reward instead of examples.
  • Refactor x_player_start variable (and the other y,z) to be a float and not a float array.
  • Add new_action["chat"] = "/effect @a minecraft:instant_health 1 10000 true" for each action such that the player can't die :)
  • Made negative rewards be "equivalent" to each other such that they will be not added to the bank.
  • When the synthesis restarts, the player will start from the best position found so far. This is a heuristic that seems to work

@nicolaefilat nicolaefilat requested a review from eErr0Re May 21, 2024 16:39
Copy link

codecov bot commented May 21, 2024

Codecov Report

Attention: Patch coverage is 5.96026% with 142 lines in your changes are missing coverage. Please review.

Please upload report for BASE (probe-with-minerl@bc0079a). Learn more about missing BASE report.

Files Patch % Lines
src/probe/probe_iterator.jl 12.24% 43 Missing ⚠️
src/minecraft/getting_started_minerl.jl 0.00% 34 Missing ⚠️
src/minecraft/create_minerl_env.jl 0.00% 33 Missing ⚠️
src/probe/update_grammar.jl 0.00% 24 Missing ⚠️
src/probe/guided_trace_search_iterator.jl 0.00% 8 Missing ⚠️
Additional details and impacted files
@@                 Coverage Diff                  @@
##             probe-with-minerl     #106   +/-   ##
====================================================
  Coverage                     ?   60.56%           
====================================================
  Files                        ?       32           
  Lines                        ?     1202           
  Branches                     ?        0           
====================================================
  Hits                         ?      728           
  Misses                       ?      474           
  Partials                     ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor Author

@nicolaefilat nicolaefilat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok is good

@eErr0Re eErr0Re merged commit 677c030 into probe-with-minerl May 24, 2024
5 checks passed
@ReubenJ ReubenJ deleted the probe-with-minerl-nick branch May 24, 2024 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants