Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to HerbGrammar v0.5 #68

Merged
merged 1 commit into from
Dec 16, 2024
Merged

Update to HerbGrammar v0.5 #68

merged 1 commit into from
Dec 16, 2024

Conversation

ReubenJ
Copy link
Member

@ReubenJ ReubenJ commented Dec 16, 2024

Remove usage of grammar-based UniformHole and RuleNode constructors. These were removed from HerbGrammar in version v0.5. See: Herb-AI/HerbGrammar.jl#96

@ReubenJ ReubenJ requested a review from THinnerichs December 16, 2024 09:39
@ReubenJ ReubenJ self-assigned this Dec 16, 2024
Copy link

codecov bot commented Dec 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.55%. Comparing base (513ebfa) to head (87e001f).

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #68      +/-   ##
==========================================
+ Coverage   75.39%   75.55%   +0.16%     
==========================================
  Files          31       31              
  Lines        1382     1387       +5     
==========================================
+ Hits         1042     1048       +6     
+ Misses        340      339       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

These were removed from `HerbGrammar` in version v0.5.
See: Herb-AI/HerbGrammar.jl#96
@ReubenJ ReubenJ merged commit 29db752 into master Dec 16, 2024
5 checks passed
@ReubenJ ReubenJ deleted the chore/grammar-v0.5 branch December 16, 2024 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants