Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pve #170

Merged
merged 31 commits into from
Sep 12, 2023
Merged

Pve #170

merged 31 commits into from
Sep 12, 2023

Conversation

aLIEzsss4
Copy link
Collaborator

No description provided.

@github-actions
Copy link

github-actions bot commented Sep 8, 2023 •
edited
Loading

Deploy preview for vercel-autochessia ready!

✅ Preview
https://vercel-autochessia-kowrngtwe-aliez.vercel.app

Built with commit edb0263.
This pull request is being automatically deployed with vercel-action

ClaudeZsb
ClaudeZsb requested changes Sep 12, 2023
View reviewed changes
packages/contracts/src/systems/AutoBattleSystem.sol Show resolved Hide resolved
packages/contracts/src/systems/AutoBattleSystem.sol Show resolved Hide resolved
packages/contracts/src/library/Utils.sol Outdated Show resolved Hide resolved
packages/contracts/src/library/Utils.sol Outdated Show resolved Hide resolved
packages/contracts/src/systems/AutoBattleSystem.sol Outdated Show resolved Hide resolved
packages/contracts/src/systems/PveSystem.sol Outdated Show resolved Hide resolved
packages/contracts/src/systems/PveSystem.sol Outdated Show resolved Hide resolved
packages/contracts/src/systems/AutoBattleSystem.sol Outdated Show resolved Hide resolved
@aLIEzsss4 aLIEzsss4 enabled auto-merge September 12, 2023 15:25
noyyyy
noyyyy approved these changes Sep 12, 2023
View reviewed changes
Copy link
Member

@noyyyy noyyyy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aLIEzsss4 aLIEzsss4 requested a review from ClaudeZsb September 12, 2023 16:29
ClaudeZsb
ClaudeZsb requested changes Sep 12, 2023
View reviewed changes
packages/contracts/src/library/Utils.sol Outdated Show resolved Hide resolved
packages/contracts/src/systems/AutoBattleSystem.sol Show resolved Hide resolved
packages/contracts/mud.config.ts Show resolved Hide resolved
packages/contracts/src/systems/PveBotSystem.sol Outdated Show resolved Hide resolved
@aLIEzsss4 aLIEzsss4 requested a review from ClaudeZsb September 12, 2023 17:25
ClaudeZsb
ClaudeZsb approved these changes Sep 12, 2023
View reviewed changes
Copy link
Collaborator

@ClaudeZsb ClaudeZsb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pr still has large room for optimization.

@aLIEzsss4 aLIEzsss4 added this pull request to the merge queue Sep 12, 2023
Merged via the queue into develop with commit 705884b Sep 12, 2023
1 check passed
@aLIEzsss4 aLIEzsss4 deleted the pve branch September 12, 2023 18:14
@ClaudeZsb ClaudeZsb linked an issue Nov 19, 2023 that may be closed by this pull request
support PvE [ need more discussion ] #43
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@noyyyy noyyyy noyyyy approved these changes

@ClaudeZsb ClaudeZsb ClaudeZsb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

support PvE [ need more discussion ]
3 participants
@aLIEzsss4 @ClaudeZsb @noyyyy