Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Broken effects of light sources (street lamps, apartments, etc.) #7

Open
2 of 3 tasks
iceeburr opened this issue Jun 8, 2024 · 0 comments
Open
2 of 3 tasks

Broken effects of light sources (street lamps, apartments, etc.) #7

iceeburr opened this issue Jun 8, 2024 · 0 comments
Assignees
@iceeburr
Labels
beginner-friendly Good first issue for people wanting to contribute to the project. priority: medium This issue may be useful, and needs some attention. semver: patch This will cause a patch bump in the version 0.0.X status: investigating This is currently being investigated and looked into. type: bug Something isn't working as expected.
Milestone
Tang County V3

Comments

@iceeburr
Copy link
Member

iceeburr commented Jun 8, 2024

Description

The light source will activate at night, but it's texture/spotlight/decal will be missing.

Reproduction Steps

  1. Go to any light source like a street lamp in the map
  2. Wait for night time in-game
  3. Light source missing certain effects and textures

Screenshots & Videos

image

Logs

No response

Operating System

No response

Additional Information

Happened due to a change on how lighting sources are grouped.
The code looks for children inside of the source's parent which broke when we grouped each lighting source separately in their own model.

Checklist

  • Reproduced the issue at least once.
  • Attached valid error logs.
  • Included screenshots of the bug happening.
@iceeburr iceeburr self-assigned this Jun 8, 2024
@Shinedown204 Shinedown204 added this to the Tang County V3 milestone Jun 8, 2024
@iceeburr iceeburr added status: investigating This is currently being investigated and looked into. type: bug Something isn't working as expected. semver: patch This will cause a patch bump in the version 0.0.X priority: medium This issue may be useful, and needs some attention. beginner-friendly Good first issue for people wanting to contribute to the project. and removed bug labels Jun 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@iceeburr iceeburr

Labels
beginner-friendly Good first issue for people wanting to contribute to the project. priority: medium This issue may be useful, and needs some attention. semver: patch This will cause a patch bump in the version 0.0.X status: investigating This is currently being investigated and looked into. type: bug Something isn't working as expected.
Projects
None yet
Milestone
Tang County V3
Development

No branches or pull requests
2 participants
@Shinedown204 @iceeburr