-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add minValue
to get the actual minimum value
#11
Comments
Hello! |
Fair enough, but I would argue that I've never seen a histogram implementation that does not provide this information. I feel like it should be provided, otherwise it's not equivalent with other histograms and code must be added to get the same functionality.
I'd be curious to see the overhead of a simple calculation such as determining the min value. I could be wrong, but I don't think it would be noticeable even at several millions of operations per second. |
|
Right now there is a
maxValue
and aminNonZeroValue
, but no way to get the realminValue
. This means the class needs to be wrapped to the real minimum value can be capture. This functionality should be built-in for cases where0
is a valid value.Given the lack of such a basic functionality, my guess is that there must be a good reason why this was not included, so happy to discuss if that's the case.
The text was updated successfully, but these errors were encountered: