Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add optimization.operand and optimization.variable to pyproject.toml #13

Merged
merged 1 commit into from
Nov 28, 2024

Conversation

xmhk
Copy link

@xmhk xmhk commented Nov 27, 2024

  • the pyproject.toml was missing build instructions for the nested modules in optimize: operand and variable.

the version on pypi works fine overall, however the Tutorial_5c_Optimization_Case_Study.ipynb example notebook throws an import error

ModuleNotFoundError: No module named 'optiland.optimization.variable'

  • the same happend when i clone the repo and built + install the local the package.
  • including explicit instructions in pyproject.toml works out

great work!

and
best regards

@xmhk
Copy link
Author

xmhk commented Nov 27, 2024

However, I noticed: now the optimizer is doing something but it is not converging towards the solution shown in the example notebook. maybe starting parameters changed?

@codecov-commenter
Copy link

codecov-commenter commented Nov 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Flag Coverage Δ
unittests 98.52% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@HarrisonKramer
Copy link
Owner

Thanks a lot for making this improvement.

I recreated the issue and see the addition in pyproject.toml fixes the error.

@HarrisonKramer
Copy link
Owner

However, I noticed: now the optimizer is doing something but it is not converging towards the solution shown in the example notebook. maybe starting parameters changed?

I see the same behavior, which is peculiar. I have made several changes to the optimization functionality over the last couple months, but hadn't caught this. I do see that changing the initial values of the lens radii of curvature brings the final optimization result to something closer to what's seen in the original notebook. I will investigate this separately, look for possible causes/bugs, and, if needed, add some tests to catch this if it happens again.

Thanks for pointing this out!

Regards,
Kramer

@HarrisonKramer HarrisonKramer merged commit 912499b into HarrisonKramer:master Nov 28, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants