-
Notifications
You must be signed in to change notification settings - Fork 587
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
documentation fixes #2805
Open
Habbie
wants to merge
7
commits into
Hammerspoon:master
Choose a base branch
from
Habbie:docs-fixes
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
documentation fixes #2805
Changes from 5 commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
55aca83
make doc builder more portable
Habbie b24a837
fix rendering of hs.dialog.textPrompt examples
Habbie 4272dad
hs.dialog.chooseFileOrFolder: fix documented allowedFileTypes default
Habbie 7ecd624
hs.dialog.chooseFileOrFolder: fix documented return type
Habbie da19e0b
improve error from build_docs.py
Habbie 85ca71d
hs.timer: fix typo
Habbie a312dc8
Update build_docs.py
cmsj File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,4 @@ | ||
#!/usr/bin/python3 | ||
#!/usr/bin/env python3 | ||
# -*- coding: utf-8 -*- | ||
"""Hammerspoon API Documentation Builder""" | ||
|
||
|
@@ -320,8 +320,8 @@ def is_actual_parameter(some_text): | |
parameter_count = len(actual_params) | ||
if parameter_count != sig_arg_count: | ||
warn("SIGNATURE/PARAMETER COUNT MISMATCH: '%s' says %d parameters ('%s'), but Parameters section has %d entries:\n%s\n" % (sig_without_return, sig_arg_count, ','.join(sig_param_arr), parameter_count, '\n'.join(actual_params))) | ||
except: | ||
warn("Unable to parse parameters for %s\n%s\n" % (item["signature"], sys.exc_info()[1])) | ||
except Exception as e: | ||
warn("Unable to parse parameters for %s\n%s\n" % (item["signature"], repr(e))) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. E501 line too long (90 > 79 characters) |
||
sys.exit(1) | ||
return module | ||
|
||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This part is no longer needed, it was already handled by another PR.