-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Saving New Outfit Causes other saved Outfit items to be lost and Loose pants too | FirestormOS 6.6.17 #153
Comments
I have been looking at this issue as well, after a report from Ashember Love (on the Rookery Pro Halcyon grid). It seems that Firestorm has made significant changes to inventory management, after version 6.6.15, such that it leaves the user account unable to login. (Halcyon can no longer find the inventory skeleton for the user.) Note that Firestorm 6.6.15 does not trigger this issue, so it is related to one of the changes in Firestorm 6.6.16 or 6.6.17. Still, the problem is somewhat permanent for a user account in that there isn't a user-manageable way to fix the missing inventory skeleton once a login is attempted with a newer Firestorm. There are a couple of separate things here, but I have always been frustrated with the inability for the Halcyon server to just repair a user with a missing skeleton, but creating a new empty one. This would at least allow the login to continue, where the user can manually adjust their appearance with the standard viewer tools. But a second concern here is that in these cases, the user does have an inventory skeleton, but attempting to login with a newer Firestorm causes that to become lost, or overwritten. I suspect maybe overwritten with a NULL UUID for the inventory root, or something like that. If you have an account that is unaffected, you can avoid the issue by avoiding the Firestorm upgrade; continue to run 6.6.15 or earlier. I'm investigating what we can do to fix the damaged inventory root. |
I attempted to log in with FS 6.6.17 and received the error: I cannot commit/PR the |
It seems there's a fundamental comms issue with the CAPS, perhaps due to "new" CAPS expected. In my local tests,
I looked back through the viewer log to see where the event queue was initialized and it seems there was a problem there:
in particular, that This could be related to a viewer change in the startup process that results in the EQG cap being used prematurely (before the region has allocated it). I'm not sure what is going on here. I don't know the CAPS system much at all and it's been years for what I do know. Just that it looks like there are some errors here that may be related. FYI, a |
It's not the CAPS error, I get the same error with 6.6.14 with a viewer that works just fine. No problems logging in or creating folders, outfits, etc with 6.6.14. My investigation ends here; I think this will require a viewer developer to diagnose which change in Firestorm isn't compatible with Halcyon, although once identified it might require a Halcyon change to fix it. |
Thank you @appurist for your efforts, I made a comment on the Firestorm issue post [FIRE-33598] and asked Beq to have a look at your comment. |
Some of this would appear to be related to a change LL made with viewers that the TPVs also abide by now relating to duplicate system folders. Viewers will now block loading any inventory if duplicated system folders are detected. The reason is because maniuplating inventory in the state of duplicate folders can cause corruption. See: https://wiki.firestormviewer.org/fs_missing_inventory for more information on Firestorm's handling of this. I suspect another part of this issue is being caused by the more recent changes relating to inventory and PBR implementation. Some of these changes have in fact introduced new CAPs which Halcyon likely does not have including the proper support pieces in the Halcyon code base. |
My guess is that Halcyon is missing changes that were applied to OpenSim core in April 2022. `commit 43a184477aaf0055542185bf787685f22cfd6b74
commit 71f856bfa86b58dd3e1554a846e7a459caeabc27
|
I don't think that those were new caps even then, I think they were introduced many years ago but were dormant, I am not 100% certain on that. However, that would be the first place I would suggest that you look. There have been a number of new caps over recent years. The PBR viewer, of course, has specific ones, these build upon the generic update caps that were part of the EEP development phase. In addition, there have been changes around estate management and other admin functions that may also be missing if you are two years or more adrift from core. |
Greetings, last month I had noticed something unusual when saving a new outfit on the new version of FirestormOS 6.6.17. The New outfit doesn't get saved, and the items/links in the previously saved outfits are lost. Plus for some weird reason the pants from another outfit got detached as well.
After a relog and tried to save the outfit again, the other items in my previously saved outfits are lost.
Thank you.
This does seem to be only happening on Halcyon. It's not happening on Osgrid. https://jira.firestormviewer.org/browse/FIRE-33598
The text was updated successfully, but these errors were encountered: