Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do we need dtauM_mmwl and dtauCIA_mmwl? #344

Open
HajimeKawahara opened this issue Feb 26, 2023 · 5 comments
Open

Do we need dtauM_mmwl and dtauCIA_mmwl? #344

HajimeKawahara opened this issue Feb 26, 2023 · 5 comments
Assignees
Labels
question Further information is requested
Milestone

Comments

@HajimeKawahara
Copy link
Owner

As discussed with @chonma0ctopus, we will rethink the necessity of opacity computation with a mmw (mean molecular weight) profile because MMR profile and molecular mass are sufficient to construct the atmospheric abundance profile.

@HajimeKawahara HajimeKawahara added the question Further information is requested label Feb 26, 2023
@HajimeKawahara HajimeKawahara modified the milestones: v1.3, v1.4 Feb 26, 2023
@HajimeKawahara
Copy link
Owner Author

any update? @chonma0ctopus I plan to remove these methods in the next release (v1.4) Is it OK?

@chonma0ctopus
Copy link
Collaborator

Sorry, no update. It is useful when investigating atomic absorption lines based on VALD using non-uniform layer-by-layer MMR until I'll implement a feature to deal with an array of different atomic masses for each atomic species to this part. (because mmw is independent of atomic species but atomic mass is.)

However, since even I have not been doing such an application recently, you may remove it.

@HajimeKawahara
Copy link
Owner Author

OK thanks!

@HajimeKawahara HajimeKawahara modified the milestones: v1.4, v2.0 Jun 14, 2023
@HajimeKawahara
Copy link
Owner Author

@YuiKasagi will use atomic lines for her analysis. Please check if dtauM_mmwl and dtauCIA_mmwl are really needed for the opacity computation of atomic lines. I postpone the decision until v2 release.

@chonma0ctopus
Copy link
Collaborator

Thank you @YuiKasagi and @HajimeKawahara. I think those functions are indeed not necessary unless you want to tweak the atomic mixing ratio layer-by-layer. (So, I can accept the option of removing them and redefining them by myself only when doing such a nerdy thing.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants