Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hires fix improvements #86

Open
tazlin opened this issue Oct 22, 2023 · 1 comment
Open

Hires fix improvements #86

tazlin opened this issue Oct 22, 2023 · 1 comment
Labels
enhancement New feature or request

Comments

@tazlin
Copy link
Member

tazlin commented Oct 22, 2023

Currently hires fix runs an initial image job at the number of input steps. If the user requests 30 steps, the worker generates a 30 step image latent with the resolution of the smallest side pinned to 512 (and the longer side, if the sizes don't match, is set so the aspect ratio is respected). The worker then runs that image latent using the same number of steps (e.g., 30 as in this example) at the final resolution.

Some thoughts on improvements:

  • The starting resolution and ending resolution could be API input options.
  • The hires steps could/should be separate, and probably should default to a small fraction of the input steps.
  • An option could be included to do non-latent upscales (which is to say, use a upscale model like ESRGAN) as in this comfy example.
@tazlin tazlin added the enhancement New feature or request label Oct 22, 2023
@spinagon
Copy link
Contributor

spinagon commented Nov 16, 2023

Or this https://gist.github.com/laksjdjf/487a28ceda7f0853094933d2e138e3c6

Update: this is now built into ComfyUI as PatchModelAddDownscale node
comfyanonymous/ComfyUI@bd07ad1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants