Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dependency qrcode breaks if version >=8.0.0 is installed #346

Open
tazlin opened this issue Oct 1, 2024 · 1 comment
Open

Dependency qrcode breaks if version >=8.0.0 is installed #346

tazlin opened this issue Oct 1, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@tazlin
Copy link
Member

tazlin commented Oct 1, 2024 •
edited
Loading

@db0 be advised the namespaces being used in hordelib for PIL compatibility are no longer valid, seen in

hordelib/hordelib/nodes/comfy_qr/qr_nodes.py

Line 10 in 8e90948

from qrcode.compat.pil import Image
.

There is no obvious notice of this in their change log for v8 and I do not know the implications of switching imports right now.

For now I am pinning the worker to <8 and that fix is already live.
@tazlin tazlin added the bug Something isn't working label Oct 1, 2024
@db0
Copy link
Member

db0 commented Oct 2, 2024

groan

tazlin added a commit that referenced this issue Oct 3, 2024
@tazlin
fix: pin dep qrcode to 7.4.2
2ebab1e 
See #346
tazlin added a commit that referenced this issue Oct 3, 2024
@tazlin
fix: pin dep qrcode to 7.4.2
d2a4bbb 
See #346
tazlin added a commit that referenced this issue Oct 3, 2024
@tazlin
fix: pin dep qrcode to 7.4.2
f8f671e 
See #346
@tazlin tazlin mentioned this issue Oct 3, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@db0 @tazlin