enable directml #356
Draft
enable directml #356
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HPPinata
force-pushed
the
directml
branch
3 times, most recently
from
d880009
to
4963ba4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should broaden our compatibility, although with significantly worse performance than native libraries.
ToDo:
Worse Performance shold be documented and advised against, before announcing this.
The PR still needs the knobs and dials to only enable directml under certain conditions, easiest would be an eqivalent to
--amdand then maybe another initialization script?Or maybe think about a way to properly detect what plattform we are running on and go from there?
Having 4 different
update-runtimescripts mostly doing the same is getting a bit out of hand...