Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for LCM lora #322

Closed
db0 opened this issue Nov 10, 2023 · 4 comments
Closed

Add support for LCM lora #322

db0 opened this issue Nov 10, 2023 · 4 comments
Labels
enhancement New feature or request

Comments

@db0
Copy link
Member

db0 commented Nov 10, 2023

https://huggingface.co/blog/lcm_lora

@db0 db0 added the enhancement New feature or request label Nov 10, 2023
@tazlin tazlin moved this to Under Consideration in AI-Horde Feature Requests Nov 10, 2023
@tazlin
Copy link
Member

tazlin commented Nov 10, 2023

As mentioned else where, this would benefit from n_iter (n on the API), especially with high end cards.

Namely, a 4090 could likely do a 4 step image in sub-second time frames (<0.7 seconds according to the paper), but initializing a comfy pipeline takes longer than that. Workers would benefit in terms of efficiency being able to batch these jobs and users would get more images for less kudos.

@db0
Copy link
Member Author

db0 commented Nov 10, 2023

Correct. Batching is very much on my priority list. I'm hoping to get the NLNet funding to work on it soon.

@tazlin
Copy link
Member

tazlin commented Nov 10, 2023

As of Haidra-Org/hordelib@261b259, the version of comfyui packaged supports LCM, and now hordelib needs the relevant changes to accept it, accounting for the fact it needs a certain sampler to work. (see here for more info).

@tazlin tazlin moved this from Under Consideration to Todo in AI-Horde Feature Requests Dec 17, 2023
@tazlin tazlin moved this from Todo to Done in AI-Horde Feature Requests Jan 8, 2024
@tazlin
Copy link
Member

tazlin commented Jan 8, 2024

This was resolved as of Haidra-Org/hordelib#132 and #337

@tazlin tazlin closed this as completed Jan 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Development

No branches or pull requests

2 participants