compression rewrite (results in a vc fix) #70

ariahiro64 · 2023-10-01T08:28:35Z

I essentially did 4 things with this commit.

Each compression algorithm uses its own function.
Added zlib as a compression algorithm as it isnt terrible on a real control deck. This includes a resizable buffer.
Every compression algorithm is forced to use Ofast which greatly improves decompression speed
Rewrote the makefile which fixes Virtual Console

Yanis002

I haven't tried it yet but I noticed few things in code

include/functions.h

spec

src/boot/lzo.c

src/boot/z_std_dma.c

src/boot/zlib.c

Yanis002 · 2023-10-01T09:31:06Z

(also don't use merge soon label when you make the PR, use the waiting for review one instead and when it gets approved use merge soon)

ariahiro64 · 2023-10-01T09:52:19Z

that should be the requested changes however we need to discuss the default memory size for zlib and perhaps use config.h?

Yanis002 · 2023-10-01T09:54:34Z

maybe create a new file called config_compression.h so we can put compresison stuff in it, otherwise that solution seems good to me

Yanis002

code is fine but I need to build this so I'll approve it once that is done

ariahiro64 · 2023-10-01T10:08:09Z

in the process of applying changes but keep in mind this isnt tested on wiivc

ariahiro64 · 2023-10-01T10:59:09Z

Just checked and Wii VC doesnt work even before this commit. So that will need to be addressed but that is out of the scope of this pr.

Yanis002

same as before I need to test before approving

Yanis002 · 2023-10-01T16:22:52Z

include/config/config_compression.h

+/* Size of libdeflates's buffer in kibibytes (yes kib not kb). HackerSM64's implimentation uses a full Mb we use 32 kib*/
+#define KIB 32
+
+#endif


newline missing there (at the end of the file)

also you should probably rename the KIB macro to something more specific to libdeflate, also there's a typo I missed on the comment there ("implimentation")

ariahiro64 · 2023-10-01T17:33:38Z

VC should now be fixed. Like stated VC doesn't benefit from optimization in fact it causes crashes. This should also be low maintenance for users. if people need insane compression the can just use zlib that's also in this pr. n64 mode uses the normal optimization levels so its mostly unchanged.

ariahiro64 · 2023-10-01T17:34:41Z

Using make wad also forces VC mode as well, I did put a warning to make clean.

Yanis002 · 2023-10-13T00:13:38Z

I tried this PR everything seems to work, I requested changes I made and sent as a diff patch so I'm gonna wait until those are applied then I'll proceed with the merge process

* ``EMULATOR :=`` -> ``N64_EMULATOR ?=`` * change other instances of EMULATOR and removed EMU_FLAGS * missing one EMULATOR

* Cleanup `z_collision_check.c` and structs * Revert `other*` names to master, split to other pr * WIP/experimental: `ColliderCylinderElement` * Revert "WIP/experimental: `ColliderCylinderElement`" This reverts commit cfc8c32ace2970869a2c93be0666786f87ca5e1a. * ac/atHitInfo -> HitElem * rename some collider elements to "elem" (instead of item, info, hurtbox...) * cut down on more "hitbox" usage * name all `ColliderElement*` temps properly * rearrange colcheck structs * add collider shape name descriptions * reword collider shape descriptions * jntsph first again --------- Co-authored-by: fig02 <[email protected]>

* Removed unused imports and other minor improvements * revert tools/ZAPD/ZAPD/genbuildinfo.py * revert diff.py * Update sym_info.py * revert asm_processor/ --------- Co-authored-by: fig02 <[email protected]> Co-authored-by: Dragorn421 <[email protected]>

* Replace most osSyncPrintf calls with PRINTF macro * DEBUG -> OOT_DEBUG

…INT_LIGHTS` (#1583) * 7 -> `ACTOR_FLAG_REACT_TO_LENS` * move comment above actor flag * 22 -> `ACTOR_FLAG_IGNORE_POINT_LIGHTS` * newlines between flags --------- Co-authored-by: fig02 <[email protected]>

HackerOoT v2.0 - Refactors & new features!

Co-authored-by: Tharo <[email protected]>

Fixed build issues with 2.0

Compiler Improvements

Avoid disabling no syncs in texture load

More detailed setup instructions

Implemented Motion Blur

Improved output of the build process

Rainbow system

Yanis002 · 2024-09-07T14:28:38Z

what's going on with this pr lol the diff is suspicious

wouldn't it be better to remake it to target the current dev branch?

ariahiro64 · 2024-09-08T00:18:27Z

this is a year old and may be quicker to redo than fix.

ariahiro64 added merge soon The pull request will be merged in 24 hours if nothing else comes up main branch The PR targets the master branch labels Oct 1, 2023

Yanis002 requested changes Oct 1, 2023

View reviewed changes

include/functions.h Outdated Show resolved Hide resolved

spec Outdated Show resolved Hide resolved

src/boot/lzo.c Outdated Show resolved Hide resolved

src/boot/z_std_dma.c Outdated Show resolved Hide resolved

src/boot/zlib.c Outdated Show resolved Hide resolved

Yanis002 added waiting for author Waiting for the author to answer questions, do changes, ... and removed merge soon The pull request will be merged in 24 hours if nothing else comes up labels Oct 1, 2023

ariahiro64 requested a review from Yanis002 October 1, 2023 09:53

Yanis002 reviewed Oct 1, 2023

View reviewed changes

ariahiro64 requested a review from Yanis002 October 1, 2023 10:59

Yanis002 added waiting for review Waiting for a contributor to review the pull request and removed waiting for author Waiting for the author to answer questions, do changes, ... labels Oct 1, 2023

Yanis002 reviewed Oct 1, 2023

View reviewed changes

Yanis002 added needs testing The pull request needs to be tested to make sure it works properly and removed waiting for review Waiting for a contributor to review the pull request labels Oct 1, 2023

ariahiro64 changed the title ~~compression rewrite~~ compression rewrite (results in a vc fix) Oct 1, 2023

Yanis002 added waiting for author Waiting for the author to answer questions, do changes, ... and removed needs testing The pull request needs to be tested to make sure it works properly labels Oct 13, 2023

Yanis002 and others added 6 commits January 9, 2024 12:49

Makefile: Change EMULATOR := to N64_EMULATOR ?= (#1608)

8a09f33

* ``EMULATOR :=`` -> ``N64_EMULATOR ?=`` * change other instances of EMULATOR and removed EMU_FLAGS * missing one EMULATOR

add OOT_DEBUG define to vscode.md (#1607)

f02d012

Replace most osSyncPrintf calls with PRINTF macro (#1598)

324db1d

* Replace most osSyncPrintf calls with PRINTF macro * DEBUG -> OOT_DEBUG

Name actor flags 1: ACTOR_FLAG_REACT_TO_LENS, `ACTOR_FLAG_IGNORE_PO…

4982f32

…INT_LIGHTS` (#1583) * 7 -> `ACTOR_FLAG_REACT_TO_LENS` * move comment above actor flag * 22 -> `ACTOR_FLAG_IGNORE_POINT_LIGHTS` * newlines between flags --------- Co-authored-by: fig02 <[email protected]>

Yanis002 and others added 24 commits April 11, 2024 00:57

run format

9feb9ac

Merge pull request HackerN64#82 from Yanis42/v2

eafdc5d

HackerOoT v2.0 - Refactors & new features!

motion blur v2

915cd9b

Co-authored-by: Tharo <[email protected]>

hopefully fixed build issues

3b83e40

hotfix to the hotfix

0a063eb

Merge pull request HackerN64#85 from Yanis42/v2_hotfix

7dce64f

Fixed build issues with 2.0

modern sdk support

21fd29d

cool output

3eb1bfb

add the blink code

dcc2a01

disable disabling no syncs with f3dex3

eb1a65d

Merge pull request HackerN64#86 from Yanis42/compiler_improvements

3500cba

Compiler Improvements

Merge pull request HackerN64#88 from Yanis42/disable_nosyncs

063b93e

Avoid disabling no syncs in texture load

Merge remote-tracking branch 'upstream/develop/2.0' into motion_blur_2

c14640b

fixed minor issues

229b3e0

more detailed instructions in INSTALLATION.md

fe83ca8

make config_game more readable

95a5041

rainbow

a1f9b52

add pause toggle

9a86acc

link to vscode.md

768d51d

"costumization"

d106160

Merge pull request HackerN64#89 from recardo-7/better-build-instructions

31611f6

More detailed setup instructions

Merge pull request HackerN64#84 from Yanis42/motion_blur_2

63304f4

Implemented Motion Blur

Merge pull request HackerN64#87 from Yanis42/cool_makefile

75a2b58

Improved output of the build process

Merge pull request HackerN64#90 from Yanis42/rainbow_v2

9d89f6a

Rainbow system

Yanis002 added 1.0 The PR targets HackerOoT v1.0 and removed main branch The PR targets the master branch labels Apr 21, 2024

Fix compression issues (HackerN64#146)

1d8e8f3

ariahiro64 force-pushed the main branch from 0ac830b to 1d8e8f3 Compare September 3, 2024 08:01

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

compression rewrite (results in a vc fix) #70

compression rewrite (results in a vc fix) #70

ariahiro64 commented Oct 1, 2023 •

edited

Loading

Yanis002 left a comment

Yanis002 commented Oct 1, 2023

ariahiro64 commented Oct 1, 2023

Yanis002 commented Oct 1, 2023

Yanis002 left a comment

ariahiro64 commented Oct 1, 2023

ariahiro64 commented Oct 1, 2023

Yanis002 left a comment

Yanis002 Oct 1, 2023

Yanis002 Oct 1, 2023

ariahiro64 commented Oct 1, 2023

ariahiro64 commented Oct 1, 2023

Yanis002 commented Oct 13, 2023

Yanis002 commented Sep 7, 2024

ariahiro64 commented Sep 8, 2024

compression rewrite (results in a vc fix) #70

Are you sure you want to change the base?

compression rewrite (results in a vc fix) #70

Conversation

ariahiro64 commented Oct 1, 2023 • edited Loading

Yanis002 left a comment

Choose a reason for hiding this comment

Yanis002 commented Oct 1, 2023

ariahiro64 commented Oct 1, 2023

Yanis002 commented Oct 1, 2023

Yanis002 left a comment

Choose a reason for hiding this comment

ariahiro64 commented Oct 1, 2023

ariahiro64 commented Oct 1, 2023

Yanis002 left a comment

Choose a reason for hiding this comment

Yanis002 Oct 1, 2023

Choose a reason for hiding this comment

Yanis002 Oct 1, 2023

Choose a reason for hiding this comment

ariahiro64 commented Oct 1, 2023

ariahiro64 commented Oct 1, 2023

Yanis002 commented Oct 13, 2023

Yanis002 commented Sep 7, 2024

ariahiro64 commented Sep 8, 2024

ariahiro64 commented Oct 1, 2023 •

edited

Loading