Use Kaze's folded polynomials #64
Conversation
ariahiro64
added
the
needs testing
|
|
||
| #ifdef DISABLE_LOOKUP_TABLE | ||
|
|
||
| #define ONE 1.0f |
There was a problem hiding this comment.
why using a macro for this? it looks weird to me 🤔 (the ONE one)
There was a problem hiding this comment.
yeah i thought i would need to do the function twice and forgot
|
it would be nice if we're implementing more optimisation stuff like this, also you should change the target of the PR to should I make dev the default branch and rename master to something like "release"? idk if this would break something (I'll probably do it after all opened PRs targeting master are merged if everyone agrees on that idea) |
|
should be good for testing |
|
I already said this on discord but I'm writing it here just for history purposes, the camera is acting weird so I'll wait until this is fixed |
include/config/config_game.h
Outdated
| @@ -9,6 +9,9 @@ | |||
| // Disables AA (Improves console performance but causes visible seams between unconnected geometry). | |||
| //#define DISABLE_AA | |||
|
|
|||
| // Use a folded polynomial instead of a lookup table. This has a speed boots and makes the calculation more precise. | |||
src/libultra/gu/sins.c
Outdated
| /** | ||
| * @param angle binang | ||
| * @return sin(angle)*0x7FFF | ||
| */ | ||
| s16 sins(u16 angle) { | ||
| #ifdef DISABLE_SIN_COS_LOOKUP_TABLE | ||
| return Math_SinS(angle) * 0x7FFF; |
There was a problem hiding this comment.
this function isn't declared (just add #include "functions.h") and it returns a f32, not s16, I feel like we should add a cast here (same comment for coss for the cast)
ariahiro64
force-pushed
the
folded_polynomial
branch
from
911ecce
to
5c7a4d1
Compare
|
farores wind crashes |
|
so ive been looking into this |
this uses Kaze Emuar's "folded polynomial" sine and cosine functions. it works by calculating a small section of the polynomial and mirrors it for the rest. this not only saves ram but seems faster than the lookup table.
Edit: forgot to mention this vastly improves animation quality.