Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PRIDE PROXI spectra returning mzs not in order #73

Open
edeutsch opened this issue Sep 12, 2020 · 3 comments
Open

PRIDE PROXI spectra returning mzs not in order #73

edeutsch opened this issue Sep 12, 2020 · 3 comments
Labels
documentation This issue is related with the documentation or repository structure enhancement New feature or request Implementation Issue related with one of the implementations proxi-schemas This issue or PR is schemas related

Comments

@edeutsch
Copy link
Contributor

Fetching a spectrum from PRIDE via PROXI such as:
http://wwwdev.ebi.ac.uk/pride/proxi/archive/v0.1/spectra?resultType=full&usi=mzspec:PXD000966:CPTAC_CompRef_00_iTRAQ_12_5Feb12_Cougar_11-10-11.mzML:scan:11850:[UNIMOD:214]YYWGGLYSWDMSK[UNIMOD:214]/2

returns the mzs in random order. This is not against the current spec, which does not specify. But it is breaking the Lorikeet viewer at ProteomeCentral. Seems like many applications may assume mzs in order.

What should be the resolution?

  • Should we update the documentation to allow mzs in any order? Write some code to compensate for out of order mzs in ProteomeCentral and all other applications?
  • Should we update the documentation to require mzs in ascending order? And update the PRIDE implementation?

Does the random order of mzs at PRIDE match the same order of intensities? One risk of separate arrays is that they become unaligned.

@ypriverol ypriverol added documentation This issue is related with the documentation or repository structure enhancement New feature or request proxi-schemas This issue or PR is schemas related labels Sep 18, 2020
@ypriverol
Copy link
Contributor

Fetching a spectrum from PRIDE via PROXI such as:
http://wwwdev.ebi.ac.uk/pride/proxi/archive/v0.1/spectra?resultType=full&usi=mzspec:PXD000966:CPTAC_CompRef_00_iTRAQ_12_5Feb12_Cougar_11-10-11.mzML:scan:11850:[UNIMOD:214]YYWGGLYSWDMSK[UNIMOD:214]/2

returns the mzs in random order. This is not against the current spec, which does not specify. But it is breaking the Lorikeet viewer at ProteomeCentral. Seems like many applications may assume mzs in order.

What should be the resolution?

sorting is fine!!!

  • Should we update the documentation to allow mzs in any order? Write some code to compensate for out of order mzs in ProteomeCentral and all other applications?
  • Should we update the documentation to require mzs in ascending order? And update the PRIDE implementation?

If we decided the do it in that way we can change our implementation.

Does the random order of mzs at PRIDE match the same order of intensities? One risk of separate arrays is that they become unaligned.

@edeutsch as far as I know they match the intensities.

@edeutsch
Copy link
Contributor Author

@ypriverol, what do you mean by "sorting is fine!!!"?

Will PRIDE start returning sorted mzs?

@ypriverol
Copy link
Contributor

@edeutsch it means that what ever we decided we can implemented.

@ypriverol ypriverol added the Implementation Issue related with one of the implementations label Mar 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation This issue is related with the documentation or repository structure enhancement New feature or request Implementation Issue related with one of the implementations proxi-schemas This issue or PR is schemas related
Projects
None yet
Development

No branches or pull requests

2 participants