Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore in htmlmin.php not working on Laravel 5.8 #135

Open
JvManuel opened this issue Apr 25, 2019 · 3 comments
Open

Ignore in htmlmin.php not working on Laravel 5.8 #135

JvManuel opened this issue Apr 25, 2019 · 3 comments

Comments

@JvManuel
Copy link

JvManuel commented Apr 25, 2019

I tried to Install Htmlmin in Laravel 5.8 and I tried to skip minification on my backend folder of the application but it is not working. I want to skip the minification on my backend folder because it has a conflict on the @Permission of Laravel.

"htmlmin.php"
'ignore' => [
'resources/views/backend'
]

@bramburn
Copy link
Contributor

Just add <!-- skip.minification --> to the files you want to ignore for now.

@rossbearman
Copy link

rossbearman commented May 14, 2019

After upgrading to Laravel 5.8 from 5.7, neither the ignore configuration option or the <!-- skip.minification --> comment are working.

Previously minificaton was working for @permission without needing to ignore any of the files. I tried switching from Blade::directive to Blade::if without luck and also using a different name for the directive.

Replacing the Blade::directive() and Blade::if() calls, with a call to directive() through $this->app['htmlmin.compiler'] fixes this, but this doesn't seem to support if() directives and it seems a bit hacky.

Any ideas on an approach that could solve this properly?

@nafplann
Copy link

Hi.. is this fixed yet?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants