Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Issues #8 and #9] ADRs for website framework and hosting #15

Merged
merged 11 commits into from
Dec 31, 2024
Merged

[Issues #8 and #9] ADRs for website framework and hosting #15

merged 11 commits into from
Dec 31, 2024

Conversation

widal001
Copy link
Collaborator

@widal001 widal001 commented Dec 30, 2024 •
edited
Loading

Summary

Changes proposed

What was added, updated, or removed in this PR.

  • Adds two ADRs:
    • Choosing Astro's Starlight docs template as our website framework
    • Choosing GitHub pages for hosting our site
  • Makes a few small updates to the ADR template

Context for reviewers

Testing instructions, background context, more in-depth details of the implementation, and anything else you'd like to call out or ask reviewers. Explain how the changes were verified.

  1. Checkout the PR
  2. Run npm run preview to build and host the site locally
  3. Review the following ADRs:

Note

I'm still working on setting up deployment previews. I tried to incorporate it in this PR, but was running into issues with overwriting the prod site.

Additional information

Screenshots, GIF demos, code examples or output to help show the changes working as expected.

Screenshot 2024-12-30 at 5 27 13 PM Screenshot 2024-12-30 at 5 25 35 PM

@widal001 widal001 temporarily deployed to github-pages-preview December 30, 2024 23:53 — with GitHub Actions Inactive
@widal001
ci: Remove PR previews
408c5d4 
They weren't working as expected. Saving for a separate issue.
@HHS HHS deleted a comment from github-actions bot Dec 31, 2024
@widal001 widal001 merged commit 81c0692 into main Dec 31, 2024
1 check passed
@widal001 widal001 deleted the issue-8-adr-website-framework branch December 31, 2024 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ADR - Website hosting ADR - Website language and framework
1 participant
@widal001