Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Prod] Bug fixes and accessibility improvements #2455

Merged
merged 28 commits into from
Nov 4, 2024
Merged

Conversation

thewatermethod
Copy link
Collaborator

@thewatermethod thewatermethod commented Nov 4, 2024

Description of change

This PR:

  • Fixes the "visited" color for the back link component to have the proper color contrast
  • Fixes the next step complete date validation so that a "close" enough date that passes the frontend won't error on the backend
  • Fixes a bug with a materialized grant view that was causing certain merges to fail
  • Properly formats the date string in the start date goals scope
  • Remove the createDate filter from affecting the TTA Type graph and the roles graph on the QA dashboard

How to test

  • Confirm the link color
  • Save a next step with a complete date of 11/11/2023 12:00pm and confirm that it doesn't error
  • Confirm with prod data that the leech lake merge from TTAHUB-3559 works
  • Visit the RTR/TTA history page and confirm that the start date and end date filters do not return an error
  • Confirm that the filter on the QA dash does not change the two graphs

Issue(s)

Checklists

Every PR

  • Meets issue criteria
  • JIRA ticket status updated
  • Code is meaningfully tested
  • Meets accessibility standards (WCAG 2.1 Levels A, AA)
  • API Documentation updated
  • Boundary diagram updated
  • Logical Data Model updated
  • Architectural Decision Records written for major infrastructure decisions
  • UI review complete

Before merge to main

  • OHS demo complete
  • Ready to create production PR

Production Deploy

  • Staging smoke test completed

After merge/deploy

  • Update JIRA ticket status

@thewatermethod thewatermethod marked this pull request as ready for review November 4, 2024 17:51
@Jones-QuarteyDana Jones-QuarteyDana merged commit d23d7cb into production Nov 4, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants