WIP: Improve sample tempo measurement #178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Testing now requires running py src/safm_api/utils_test.py [space-separated list of files]
# The argument can be left blank, in which case the content of the `test` folder will be used |
I thought this could be avoided, but it will have to be removed before the end of the merge
|
Kudos, SonarCloud Quality Gate passed!
|
qtipee
approved these changes
Nov 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When done, will close #173 .
What remains to be done is find a set of criteria that can determine whether a sample's tempo can be accurately measured, based on the histogram of the possible bpms detected.
Due to a perplexing problem on my part, I can't seem to make
aubiorun on.wavfiles. This has in effect allowed me to have a couple of examples of bad samples (from the various.mp3s present on the school-hosted site), but a severe lack of good, clean examples.So, I am asking for someone with a functioning
aubioinstalled to rundeduce_tempo.pyon a clean sample such as :PS: For as long as visual debugging is required, the
deduce_tempo.pyscript requires the additional librarymatplotlib.