Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need to Remove EAX references from UI #247

Closed
patmauro opened this issue Nov 14, 2023 · 0 comments · Fixed by #251
Closed

Need to Remove EAX references from UI #247

patmauro opened this issue Nov 14, 2023 · 0 comments · Fixed by #251

Comments

@patmauro
Copy link
Contributor

EAX is dead and is not coming back - so even though there is an ongoing effort to emulate these via EFX, it would still be prudent to remove the references in the UI to the EAX technology specifically, especially given how much of Uru's sound logic has already been ripped out in favor of OpenAL.

Specifically, we need to do the following:

  • Remove the EAX graphic at the bottom of the Audio Settings menu.
  • Either hide the "Enable EAX" option outright until an EFX solution is ready, or simply replace the string with "Enable EFX," and allow this to similarly be greyed out until an EFX fix is ready.
  • Since this is a UI change, the changes should be done via xKIGUI.max.

PR #239 attempted to solve this issue by replacing the EAX graphic with an OpenAL graphic and by directly modifying GUI_District_AudioSettingsDialog.prp to change the "Enable EAX" string to "Enable EFX" - however, the feedback was that (A) we should instead remove the graphic outright, and (B) the needed changes should instead be made in xKIGUI.max and reexported afresh so that the source files can reproduce the game files exactly.

Hoikas added a commit to Hoikas/moul-assets that referenced this issue Feb 25, 2024
Removes the EAX logo from the audio settings dialog.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant