MQO reading #251
Draft
MQO reading #251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hoikas
reviewed
Jul 17, 2022
| @@ -85,6 +85,7 @@ class HSPLASMA_EXPORT PlasmaVer | |||
| pvPrime = MAKE_VERSION(2, 0, 63, 11), | |||
| pvPots = MAKE_VERSION(2, 0, 63, 12), | |||
| pvMoul = MAKE_VERSION(2, 0, 70, 0), | |||
| pvMqo = MAKE_VERSION(2, 0, 70, 1), | |||
There was a problem hiding this comment.
H-uru/Plasma is currently 2.0.70.2, FWIW.
There was a problem hiding this comment.
That ends up not really mattering because that's handled via the ClassVersions stuff.
MQO isn't really 2.0.70.1, we just need something to use as a flag because of the missing ClassVersions for messages :(
I believe this is only ever used for MQO.
Co-Authored-By: Edmond Mondor <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on some work by @Hazado and references from Drizzle, this seems to be able to read all the MQO files. I'm going to say that editing/writing is probably not safe for now.
For most cases, we can rely on the Class Versions map, except for the case of messages included within responders. That necessitated the addition of a
pvMqoentry to PlasmaVersion and a very specific filename/SeqPrefix check to decide when to use it or not 😞This also adds support for the plCloneSpawnModifier class. Currently this is unused in Uru and MOUL, so we'll always try to read an MQO version if it's MOUL-ish data. Given that the class implementation is actually probably broken in Uru, it makes sense for us to update it in H-uru/Plasma to match MQO at some point so that it's actually usable, but that's neither here nor there.
There's a handful of version checks for Choru data that I've been carrying around locally for a few years in here too. I can try to split them out into their own commit if that's a problem.
Closes #247