Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attempt to fix crash after receiving a KickedOff message #1521

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from

Commits on Nov 3, 2023

  1. Assert that socket is open before trying to operate on it

    Otherwise the operations fail with an invalid handle error, which is a
    bit less obvious when debugging.
    dgelessus committed Nov 3, 2023
    Configuration menu
    Copy the full SHA
    a5af3f2 View commit details
    Browse the repository at this point in the history
  2. Lock more consistently during socket operations

    Every AsyncSocket is guarded by its own fCritsect. All ConnectOperations
    are guarded by the shared s_connectCrit.
    dgelessus committed Nov 3, 2023
    Configuration menu
    Copy the full SHA
    9c979fc View commit details
    Browse the repository at this point in the history

Commits on Nov 4, 2023

  1. Fix crash after receiving an Auth2Cli_KickedOff message

    Apparently the NetCli infrastructure and/or our asio-based sockets
    really don't like it when a socket is closed inside its own notify read
    callback. So instead, let ReportNetError disconnect the auth connection
    via the error callback, which runs asynchronously on the main thread.
    dgelessus committed Nov 4, 2023
    Configuration menu
    Copy the full SHA
    8a73bfc View commit details
    Browse the repository at this point in the history