Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(proxies): use pypac to use PAC file #560

Merged
merged 5 commits into from
Oct 4, 2024
Merged

Conversation

jmkerloch
Copy link
Collaborator

@jmkerloch jmkerloch commented Oct 1, 2024

Introduce support for PAC file for proxy definition.

QDT will first try to use QDT_PROXY_HTTP environment variable then new environment variable QDT_PAC_FILE for custom PAC file then system PAC if available.

@github-actions github-actions bot added dependencies Project dependencies. quality Tests, project resiliency, etc. labels Oct 1, 2024
@codecov-commenter
Copy link

codecov-commenter commented Oct 2, 2024

Codecov Report

Attention: Patch coverage is 82.75862% with 5 lines in your changes missing coverage. Please review.

Project coverage is 70.86%. Comparing base (81e2b4d) to head (a866e54).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
qgis_deployment_toolbelt/utils/proxies.py 82.14% 3 Missing and 2 partials ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #560      +/-   ##
==========================================
- Coverage   71.00%   70.86%   -0.14%     
==========================================
  Files          47       47              
  Lines        3135     3158      +23     
  Branches      671      680       +9     
==========================================
+ Hits         2226     2238      +12     
- Misses        718      728      +10     
- Partials      191      192       +1     
Flag Coverage Δ
unittests 70.29% <82.75%> (-0.14%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
qgis_deployment_toolbelt/commands/upgrade.py 62.63% <ø> (ø)
...eployment_toolbelt/profiles/remote_http_handler.py 36.53% <ø> (ø)
qgis_deployment_toolbelt/utils/file_downloader.py 77.04% <100.00%> (ø)
qgis_deployment_toolbelt/utils/proxies.py 66.66% <82.14%> (-10.76%) ⬇️

@github-actions github-actions bot added the documentation Improvements or additions to documentation label Oct 2, 2024
@jmkerloch jmkerloch marked this pull request as ready for review October 2, 2024 09:20
@jmkerloch jmkerloch force-pushed the feat/pypac_auto_proxy branch 2 times, most recently from 80bdeb0 to f0bb8dc Compare October 2, 2024 10:09
docs/guides/howto_behind_proxy.md Outdated Show resolved Hide resolved
docs/guides/howto_behind_proxy.md Show resolved Hide resolved
qgis_deployment_toolbelt/utils/proxies.py Outdated Show resolved Hide resolved
requirements/base.txt Outdated Show resolved Hide resolved
tests/fixtures/pac/proxy.pac Outdated Show resolved Hide resolved
jmkerloch and others added 4 commits October 4, 2024 16:46
Copy link

sonarcloud bot commented Oct 4, 2024

@jmkerloch jmkerloch merged commit 3c081dc into main Oct 4, 2024
28 checks passed
@jmkerloch jmkerloch deleted the feat/pypac_auto_proxy branch October 4, 2024 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Project dependencies. documentation Improvements or additions to documentation quality Tests, project resiliency, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants