Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(AH) video implementation #60

Open
ah-bas-und-aer opened this issue Oct 17, 2024 · 14 comments
Open

(AH) video implementation #60

ah-bas-und-aer opened this issue Oct 17, 2024 · 14 comments

Comments

@ah-bas-und-aer
Copy link
Collaborator

Solution: Video will be embeded into our own server space and with the “video element“ on top of the main page
-> B&A: decesion how to style the image on top of the page
-> Guide: Edits CSS

Question: No adding of cookie window or further data privacy is needed, correct?

@ah-bas-und-aer
Copy link
Collaborator Author

ah-bas-und-aer commented Oct 21, 2024

@GuidaGG The video will probably be set as on the dev-page, the thing I would like you to do is to reduce the top hight.
It says 10rem, please change it to 7, just below the gradiant.

How much would it cost to set the video as a full screnn landing area? And the header gradiant full width or – even better – appear after scrolling down the video and then stay on top?

@ah-bas-und-aer
Copy link
Collaborator Author

Uploading Bildschirmfoto 2024-10-21 um 18.08.44.png…

@ah-bas-und-aer
Copy link
Collaborator Author

Bildschirmfoto 2024-10-21 um 18 16 04 Bildschirmfoto 2024-10-21 um 18 08 44

@GuidaGG
Copy link
Owner

GuidaGG commented Oct 22, 2024

Dear Astrid,

can you check if the example I did is what you expect?

  • the video takes always the height accordingly to the screen size; in some cases so that the video fits in height and the subtitles are showned, the width is slightly smaller than the screen
  • I think the autoplay will not always work, depends on browser and security. Maybe we could have a default play button in case?

https://dev.vielfaeltig-bremen.de/

to implement this properly I need between 2-3 hours.

@ah-bas-und-aer
Copy link
Collaborator Author

ah-bas-und-aer commented Oct 22, 2024 via email

@GuidaGG
Copy link
Owner

GuidaGG commented Oct 22, 2024

  • the thing is, because the video has a specific format, if i put it 100% of the width, the height will be a lot of times bigger than the height of the screne, which means the subtitles/bottom part of the video is cut. It is a decision you have to make, either priority of the height or of the width,
  • yes, the idea is to have it just on homepage, but i didnt implemented it.
  • can you make the button play like the arrow buttons we use?

@ah-bas-und-aer
Copy link
Collaborator Author

I see, this was not a problem for me, because on my screen it fits perfectly. The only thing i can imagine having a full width would be to use a mask and crop not the bottom of the video but the top, in case the screen does not have the hight.
Dies this makes sense?

@GuidaGG
Copy link
Owner

GuidaGG commented Oct 22, 2024

I will try some options when we implement it.

@ah-bas-und-aer
Copy link
Collaborator Author

Clever woman because we go for the other option :)
The easier on. For this, I would like you to reduce the spacing above the video as I mentioned in the second commment here. Also I will create an icon for “Play“

@ah-bas-und-aer
Copy link
Collaborator Author


vielfaeltig_Icon_Pause_RZ
vielfaeltig_Icon_Play_RZ
vielfaeltig_Icon_Stop_RZ

@ah-bas-und-aer
Copy link
Collaborator Author

here are the icons of you desire

@GuidaGG
Copy link
Owner

GuidaGG commented Oct 25, 2024

@ah-bas-und-aer can you check the implementation?
space and buttons are on.

@ah-bas-und-aer
Copy link
Collaborator Author

@GuidaGG I uploaded the mp4 video file, can we use this as suggested in case the webm is not working?

@GuidaGG
Copy link
Owner

GuidaGG commented Oct 31, 2024

Hi Astrid,

Can you please test if the video is now working?
so the implmentation of the sources and the buttons are not default from the video-block, so I will post here the code that you need to use whenever you would like to use a video. We still need to confirm this is working but I will already leave here the code, because at least for the buttons it is necessary

<!-- wp:video {"id":414} -->
<figure class="wp-block-video"><video autoplay controls muted>
<source src="https://dev.vielfaeltig-bremen.de/wp-content/uploads/2024/10/CND-1135_vielfaeltig_Imagespot_Master_4K_webM.webm">
<source src="https://dev.vielfaeltig-bremen.de/wp-content/uploads/2024/10/CND-1135_vielfaeltig_Imagespot_Master_4K_med_Q_UT.mp4">
</video>

<!-- wp:buttons -->
<div class="wp-block-buttons video-buttons"><!-- wp:button {"className":"play-button"} -->
<div class="wp-block-button play-button"><a class="wp-block-button__link wp-element-button"><img class="wp-image-499"  src="https://dev.vielfaeltig-bremen.de/wp-content/uploads/2024/10/379857208-e267321d-c9b7-44d6-a51c-ea62d09baead.svg" alt="Zum Abspielen klicken"></a></div>
<!-- /wp:button -->

<!-- wp:button {"className":"pause-button"} -->
<div class="wp-block-button pause-button"><a class="wp-block-button__link wp-element-button"><img class="wp-image-498" src="https://dev.vielfaeltig-bremen.de/wp-content/uploads/2024/10/379857205-aa1d2e9c-b9f3-4d09-885c-f680e957815c.svg" alt="Pause Button"></a></div>
<!-- /wp:button --></div>
<!-- /wp:buttons -->
</figure>
<!-- /wp:video -->

You can have the code view of the page by going to:

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants