From f47ef314cde7371fae185bcd947b9a856735df55 Mon Sep 17 00:00:00 2001 From: Greg Chadwick Date: Sun, 7 May 2023 22:25:59 +0100 Subject: [PATCH] An RTL change --- .github/workflows/pr_change_check.yml | 40 ------------------- BLOCKFILE | 1 - hw/ip/otbn/rtl/otbn.sv | 3 -- hw/ip/otbn/rtl/otbn_core.sv | 7 ---- .../alert_handler/rtl/alert_handler.sv | 2 - 5 files changed, 53 deletions(-) delete mode 100644 .github/workflows/pr_change_check.yml diff --git a/.github/workflows/pr_change_check.yml b/.github/workflows/pr_change_check.yml deleted file mode 100644 index 9f1155dd5989ff..00000000000000 --- a/.github/workflows/pr_change_check.yml +++ /dev/null @@ -1,40 +0,0 @@ -# Copyright lowRISC contributors. -# Licensed under the Apache License, Version 2.0, see LICENSE for details. -# SPDX-License-Identifier: Apache-2.0 -name: 'Check for and block unauthorized changes' - -on: - pull_request_target: - -permissions: - contents: read - # Needed to read comments for authorizations - pull-requests: read - -jobs: - check-changes: - runs-on: "ubuntu-latest" - steps: - - name: Checkout - uses: actions/checkout@v3 - with: - fetch-depth: 0 - - - name: Determine changed files - run: | - pr_ref="refs/pull/${{ github.event.number }}/merge" - echo $pr_ref - git fetch origin $pr_ref - git diff --name-only \ - "origin/${{ github.base_ref }}" \ - FETCH_HEAD > $HOME/changed_files - - - name: Show files changed - run: cat $HOME/changed_files - - - name: Check for blocked changs - run: | - ./ci/scripts/check-pr-changes-allowed.py $HOME/changed_files \ - --gh-repo ${{ github.repository }} \ - --gh-token ${{ secrets.GITHUB_TOKEN }} \ - --pr-number ${{ github.event.number }} diff --git a/BLOCKFILE b/BLOCKFILE index 15e665d55a586c..1e8ab4612230b1 100644 --- a/BLOCKFILE +++ b/BLOCKFILE @@ -15,4 +15,3 @@ # # At least two committers must authorize the change to pass. -hw/ip/*/rtl/* diff --git a/hw/ip/otbn/rtl/otbn.sv b/hw/ip/otbn/rtl/otbn.sv index f7f2189bea977f..643d2a68dbcfd7 100644 --- a/hw/ip/otbn/rtl/otbn.sv +++ b/hw/ip/otbn/rtl/otbn.sv @@ -188,9 +188,6 @@ module otbn .NumCopies(1) ) u_lc_rma_req_sync ( .clk_i, - .rst_ni, - .lc_en_i(lc_rma_req_i), - .lc_en_o({lc_rma_req}) ); // Internally, OTBN uses MUBI types. diff --git a/hw/ip/otbn/rtl/otbn_core.sv b/hw/ip/otbn/rtl/otbn_core.sv index e7f7a7144e549c..9babf2463dfe4a 100644 --- a/hw/ip/otbn/rtl/otbn_core.sv +++ b/hw/ip/otbn/rtl/otbn_core.sv @@ -303,13 +303,6 @@ module otbn_core .secure_wipe_ack_o (secure_wipe_ack), .secure_wipe_running_o, .done_o, - - .sec_wipe_wdr_o (sec_wipe_wdr_d), - .sec_wipe_wdr_urnd_o (sec_wipe_wdr_urnd_d), - .sec_wipe_base_o (sec_wipe_base), - .sec_wipe_base_urnd_o(sec_wipe_base_urnd), - .sec_wipe_addr_o (sec_wipe_addr), - .sec_wipe_acc_urnd_o(sec_wipe_acc_urnd), .sec_wipe_mod_urnd_o(sec_wipe_mod_urnd), .sec_wipe_zero_o (sec_wipe_zero), diff --git a/hw/ip_templates/alert_handler/rtl/alert_handler.sv b/hw/ip_templates/alert_handler/rtl/alert_handler.sv index 96ca04d0739b1c..5584da59436f82 100644 --- a/hw/ip_templates/alert_handler/rtl/alert_handler.sv +++ b/hw/ip_templates/alert_handler/rtl/alert_handler.sv @@ -21,8 +21,6 @@ module alert_handler input clk_edn_i, input rst_edn_ni, // Bus Interface (device) - input tlul_pkg::tl_h2d_t tl_i, - output tlul_pkg::tl_d2h_t tl_o, // Interrupt Requests output logic intr_classa_o, output logic intr_classb_o,