Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate event system to use node events lib. #22

Open
dadiorchen opened this issue Nov 11, 2021 · 3 comments
Open

Migrate event system to use node events lib. #22

dadiorchen opened this issue Nov 11, 2021 · 3 comments
Labels
enhancement New feature or request good first issue Good for newcomers high-priority

Comments

@dadiorchen
Copy link
Collaborator

We impletement the event system by simply call onXXX function parten, in this PR #20 #21 we try to use events lib to provide a solid and battle checked approach to implement event system, please migrate all other onXXX event to use
These listner is like onError, onLoad...


Some hints:

  • Please read our readme for more information/guide/tutorial.
  • Here is an engineering book in Greenstand.
  • To know more about our organization, visit our website.
  • If you want to join the slack community (some resources need the community member's permission), please leave your email address.
@dadiorchen dadiorchen added enhancement New feature or request good first issue Good for newcomers labels Nov 11, 2021
@keyy123
Copy link
Contributor

keyy123 commented Dec 11, 2022

@dadiorchen If this issue is still open, I would like to handle it! 🙂

@dadiorchen
Copy link
Collaborator Author

@Mohmn I think you did something related to this?

@Mohmn
Copy link
Member

Mohmn commented Dec 20, 2022

yes , i was trying to provide a unsubscribing func

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers high-priority
Projects
No open projects
Status: No status
Development

No branches or pull requests

3 participants