Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Greenstand-Token.md #146

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Davidezrajay
Copy link
Contributor

Removed TRing as ERC20 token to align with TRing Creation process.
Removed notes on Terminology and representation of the current system.
Renamed a 100th of a Tring to a Seed.

Removed TRing as ERC20 token. 
Removed notes
Renamed a 100th of a Tring to a Seed.
Copy link

@bstetzer32 bstetzer32 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few comments. Let me know if you have any questions.

@@ -584,7 +581,7 @@ Globally ‘tree planting’ is currently being counted as a “pledge” or as
**TRing**


TRing is the native currency of the Greenstand network. They are created by depositing Greenstand Tokens. The number of TRings produced per Greenstand Token is calculated using the Master Relative Value Index. A TRing is divisible by 100 to create Grain.
TRing is the native currency of the Greenstand network. They are created by depositing Greenstand Tokens. The number of TRings produced per Greenstand Token is calculated using the Master Relative Value Index. A TRing is divisible by 100 to create Seed.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://academy.binance.com/en/glossary/wei
In my opinion, we should conform to the existing standard to the best of our ability. I will defer to your judgement, however.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @bstetzer32 This is a good point.
We should certainly stick with the existing standard, although I believe it should be renamed.
Do you have any ideas there? - 10^18 is a big number.

Comment on lines +547 to +550
**Seed**

A Seed is 100th of a TRing.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://academy.binance.com/en/glossary/wei
In my opinion, we should conform to the existing standard to the best of our ability. I will defer to your judgement, however.


The TRing is divisible by 100 units called Grain.
The TRing is divisible by 100 units called Seed.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://academy.binance.com/en/glossary/wei
In my opinion, we should conform to the existing standard to the best of our ability. I will defer to your judgement, however.

@@ -434,9 +430,9 @@ Sealing nodes are compensated using minting and transfer fees based on the value

A TRing is the native currency of the Greenstand network and is created by depositing Greenstand tokens.

The Greenstand Token resides on the network as an ERC721 token. Any Greenstand Token may be converted into TRings as an ERC20. The number of TRrings created from this conversion is calculated using the Greenstand network’s master RVI.
The Greenstand Token resides on the network as an ERC721 token. Any Greenstand Token may be converted into TRings. The number of TRrings created from this conversion is calculated using the Greenstand network’s master RVI.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
The Greenstand Token resides on the network as an ERC721 token. Any Greenstand Token may be converted into TRings. The number of TRrings created from this conversion is calculated using the Greenstand network’s master RVI.
The Greenstand Token resides on the network as an ERC721 token. Any Greenstand Token may be converted into TRings. The number of TRrings created from this conversion is calculated using the Greenstand network’s master RVI. This master RVI will be implemented into the Smart Contract(s) responsible for accepting the ERC721 token in exchange for TRings/Seed. If an organization wishes to create their own Smart Contract that implements a seperate RVI calculatuon, they will be able to deploy seperate contracts with other calculation methodologies. The nature of the ERC721 token will ensure that the authorized nodes will always receive their fair share of each ERC721 transaction, and the Greenstand master RVI will be continuously updated through consensus of authorized nodes to ensure that the master RVI is always the standard.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants