Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check system timezone #21

Closed
colinsauze opened this issue May 4, 2023 · 2 comments
Closed

Check system timezone #21

colinsauze opened this issue May 4, 2023 · 2 comments

Comments

@colinsauze
Copy link
Member

The carbon intensity data we are given is in UTC. But system time could be in a different timezone. We need to translate this when producing the output from cats, currently we don't. We should also write unit tests to check this and to check what happens when the clocks change as this is a common way systems like this break!

@abhidg
Copy link
Contributor

abhidg commented May 5, 2023

👍 https://xkcd.com/1883/ :)

@andreww
Copy link
Collaborator

andreww commented Aug 11, 2023

Fixed by #61

@andreww andreww closed this as completed Aug 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants