Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mislabeled and duplicated tests in controller spec #134

Open
Jonathan-Zollinger opened this issue Jun 19, 2024 · 0 comments
Open

mislabeled and duplicated tests in controller spec #134

Jonathan-Zollinger opened this issue Jun 19, 2024 · 0 comments

Comments

@Jonathan-Zollinger
Copy link
Member

Summary

tests "query pdp for #tcinArg tcin strings"() and "query product summaries with no error tcin type arg"() are duplicates (pdp test is mislabeled). #133 is also heavily applicable

both tests excerpt
void "query pdp for #tcinArg tcin strings"() {
        when:
        if (count == 1){
            threshrController.fetchProductSummaries(targetStore, tcinArg as String)
        }else {
            threshrController.fetchProductSummaries(targetStore, tcinArg as String[])
        }

        then:
        noExceptionThrown()

        where:
        tcinArg                       | count
        tcin.getTcins().split(",")[0] | 1
        tcin.getTcins().split(",")    | 2

    }

    void "query product summaries with no error tcin type arg"() {
        when:
        threshrController.fetchProductSummaries(targetStore, tcinArg)

        then:
        noExceptionThrown()

        where:
        tcinArg                                 | _
        tcin                                    | _
        new Tcin(tcin.getTcins().split(",")[0]) | _
    }
@Jonathan-Zollinger Jonathan-Zollinger modified the milestones: Release 0.0.14, Release 0.0.15 Jun 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant