Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Render below status bar in portrait orientation on devices with a display cutout #319

Conversation

soupslurpr
Copy link
Member

On devices with a display cutout, instead of hiding the status bar which shows a black bar, this makes it render below the bar by not hiding it when in portrait. Also uses the newer way to get the WindowInsetsController for SDKs supporting it.

@matchboxbananasynergy
Copy link

Thanks! Are you able to provide screenshots of what the app looks like now, and what it looks like with this PR?

@soupslurpr
Copy link
Member Author

Yeah sure, here you go:

Before:
Screenshot_20231218_120056

After:
Screenshot_20231218_115954

@thestinger thestinger force-pushed the main branch 2 times, most recently from 2d660f2 to c9eb422 Compare April 22, 2024 22:26
@soupslurpr soupslurpr closed this Jul 9, 2024
@soupslurpr soupslurpr force-pushed the render-below-status-bar-on-devices-with-display-cutout branch from 8e6081e to 426a81c Compare July 9, 2024 07:40
@soupslurpr soupslurpr reopened this Jul 9, 2024
@soupslurpr
Copy link
Member Author

soupslurpr commented Nov 28, 2024

Target SDK 35 makes apps render edge-to-edge. Version 20 renders it fullscreen without the status bar being visible because its target SDK has been raised to 35.

@soupslurpr soupslurpr closed this Nov 28, 2024
@soupslurpr soupslurpr deleted the render-below-status-bar-on-devices-with-display-cutout branch November 28, 2024 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants