Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the ability to open files #25

Open
jamespfluger opened this issue Apr 24, 2020 · 0 comments
Open

Add the ability to open files #25

jamespfluger opened this issue Apr 24, 2020 · 0 comments

Comments

@jamespfluger
Copy link
Contributor

eXeMeL already allows auto-loading content from the clipboard, and saving the contents to an XML file. However, it does not allow deliberate opening of a file.

This can be easily implemented by adding a command extremely similar to SaveCommand_Execute, but using OpenFileDialog instead of the save. Additionally, the OpenFileAsync method already exists and can be called from within. However, that method cannot be awaited because it returns void.

Things to consider:

  1. Is it worth creating a new non-async method for OpenFile? The code would be nearly identical, so I don't think it makes sense.
  2. What icon should be used for the open command? The appbar.folder.open icon from the source of the rest doesn't look great because of how small it is. This assumes no additional resizing happens.
  3. Where does the icon fall in the toolbar? Open is traditionally to the left of Save, but all the buttons are placed on the right side.

I've already got a working version of this, but I want to refine it some more. And finalize the items listed above.

jamespfluger added a commit to jamespfluger/eXeMeL that referenced this issue Apr 26, 2020
- Added button to open file
- Added hotkey to open file
- Added new Command to trigger opening of file
- Added icon for opening
@jamespfluger jamespfluger mentioned this issue Apr 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant