Skip to content
This repository has been archived by the owner on Sep 15, 2021. It is now read-only.

Warn user or auto-split flags with space #19

Open
coollog opened this issue Oct 9, 2017 · 4 comments
Open

Warn user or auto-split flags with space #19

coollog opened this issue Oct 9, 2017 · 4 comments

Comments

@coollog
Copy link
Contributor

coollog commented Oct 9, 2017

If the user uses a flag with a space in it, like:

minikubeStart {
  flags = ["--vm-driver none"]
}

The CommandExecutor will fail to run this command because the space is escaped (it will run minikube start --vm-driver\ none).

We can resolve this by warning the user that they have a space in the flag or by automatically splitting this into two parts for the command list.

@loosebazooka
Copy link
Member

what if they want a flag parameter with spaces in it?
Are you tracking with --?

@coollog
Copy link
Contributor Author

coollog commented Oct 9, 2017

Currently, if they want a flag parameter with spaces in it, they would have to split up the parameter, like:

minikubeStart {
  flags = ["--vm-driver", "none"]
}

@loosebazooka
Copy link
Member

loosebazooka commented Oct 9, 2017

oh right, but I mean flags = ["--vm-driver", "my vm driver"] <- auto escaping is a feature in this case

@coollog
Copy link
Contributor Author

coollog commented Oct 9, 2017

Yes, that should remain as a feature. Not sure what the best way to approach this may be. Maybe when executing a command, we can log it with the escape symbols, so like:

Instead of: Running command : minikube --vm-driver none
We have: Running command : minikube --vm-driver\ none

This is just a small ux improvement though.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants