Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RepoSync: Label character limit at 63 #949

Open
mdudek579 opened this issue Oct 18, 2023 · 0 comments
Open

RepoSync: Label character limit at 63 #949

mdudek579 opened this issue Oct 18, 2023 · 0 comments

Comments

@mdudek579
Copy link

RepoSync: Label character limit at 63

We’d like to use more descriptive names which is another issue.
In the future we'll have plenty of RepoSync objects deployed to the cluster so we need to have good naming convention for them.
When using longer, more descriptive names we're facing following error:

Deployment.apps "ns-reconciler-abcd-1234567-asddffgh000-xyz-asdfghjt-abc-reposync-8" is invalid: [spec.selector.matchLabels: Invalid value: "ns-reconciler-abcd-1234567-asddffgh000-xyz-asdfghjt-abc-reposync-8": must be no more than 63 characters, spec.selector: Invalid value: v1.LabelSelector{MatchLabels:map[string]string{"app":"reconciler", "configsync.gke.io/deployment-name":"ns-reconciler-abcd-1234567-asddffgh000-xyz-asdfghjt-abc-reposync-8"}, MatchExpressions:[]v1.LabelSelectorRequirement(nil)}: invalid label selector]

Deployment name is build from following pieces: ns-reconciler-${namespace}-${reposyncname}-${number}
Given that namespace and reposync names can be up to 63 characters it's not easy for reconcilers deployments to have names shorter than 63 characters which is combination of elements mentioned before.
In our implementation we would like label selector to be able to accept labels longer than 63 characters.

We are aware that changing label character limit is a deep change in Kubernetes so our alternative request is to use different label selector in the process.

https://cloud.google.com/anthos-config-management/docs/reference/labels-and-annotations

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant