Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updating tedious in mssql docs sample #154

Open
ruyadorno opened this issue Jul 10, 2023 · 2 comments
Open

Updating tedious in mssql docs sample #154

ruyadorno opened this issue Jul 10, 2023 · 2 comments
Assignees
@jackwotherspoon
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: cleanup An internal cleanup or hygiene concern. type: docs Improvement to the documentation for an API.

Comments

@ruyadorno
Copy link
Contributor

ruyadorno commented Jul 10, 2023 •
edited
Loading

In order to get the current mssql-based SQL Server sample working on https://github.com/GoogleCloudPlatform/nodejs-docs-samples/tree/main/cloud-sql/sqlserver/mssql we'll need to make sure mssql is using a newer version of tedious, which supports the connector config property which in turn enable support to the Cloud SQL Node.js Connector.

Once mssql is updated upstream we should be able to update our SQL Server doc sample to start using the Node.js Connector package.

Related to: #140
@ruyadorno ruyadorno added the type: docs Improvement to the documentation for an API. label Jul 10, 2023
@ruyadorno
Copy link
Contributor Author

ruyadorno commented Jul 10, 2023 •
edited
Loading

Update: Opened a PR in mssql to try and start that conversation with their maintainers, there are a few issues at play though, like the fact that the new version of tedious dropped support to node14 which in turn will require a semver-major bump in mssql next release (once that update lands).

Ref: tediousjs/node-mssql#1500

@enocom enocom added priority: p2 Moderately-important priority. Fix may not be included in next release. type: cleanup An internal cleanup or hygiene concern. labels Jul 10, 2023
@ruyadorno ruyadorno mentioned this issue Jul 12, 2023
Closed
@edosrecki
Copy link
Contributor

@ruyadorno this was just released in mssql v10: https://github.com/tediousjs/node-mssql/releases/tag/v10.0.0

ruyadorno added a commit that referenced this issue Jan 25, 2024
@ruyadorno
chore: remove tedious version override
a26a8c9 
Now that an updated version of `mssql` >= 10 has landed, we no longer
need the specifier override used for pinning `tedious` in our
`package.json` file.

Refs: #260
Refs: #154
ruyadorno added a commit that referenced this issue Jan 25, 2024
@ruyadorno
chore: remove tedious version override
8541164 
Now that an updated version of `mssql` >= 10 has landed, we no longer
need the specifier override used for pinning `tedious` in our
`package.json` file.

Refs: #260
Refs: #154
@ruyadorno ruyadorno mentioned this issue Jan 25, 2024
Merged
ruyadorno added a commit that referenced this issue Jan 25, 2024
@ruyadorno
chore: remove tedious version override (#295)
3004435 
Now that an updated version of `mssql` >= 10 has landed, we no longer
need the specifier override used for pinning `tedious` in our
`package.json` file.

Refs: #260
Refs: #154
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jackwotherspoon jackwotherspoon

Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: cleanup An internal cleanup or hygiene concern. type: docs Improvement to the documentation for an API.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@ruyadorno @enocom @edosrecki @jackwotherspoon