Polyfill doesn't work

[FluorescentHallucinogen]

Steps to reproduce:

• Use a browser that doesn't support MediaStream Image Capture API.
• Use the polyfill.

Expected results without using the polyfill:

'ImageCapture' in window // returns false

Expected results with using the polyfill:

'ImageCapture' in window // returns true

Actual results with using the polyfill:

'ImageCapture' in window // returns false

[FluorescentHallucinogen]

@dandv PTAL.

[FluorescentHallucinogen]

@YellowDoge @beaufortfrancois @samdutton PTAL.

[beaufortfrancois]

@dandv I can reproduce on https://imagecapture.js.org/ with Safari. Can you have a look at why it fails?

[FluorescentHallucinogen]

@KaptenJansson PTAL.

[dandv]

@beaufortfrancois and @FluorescentHallucinogen: I've merged some PRs to address Safari compatibility. Can you please test the latest build?

[FluorescentHallucinogen]

@dandv I opened this issue not because the polyfill didn't work in Safari, but because it didn't work in all (any) browsers that don't support Image Capture API natively (without enabling experimental flags), e.g. Firefox.

What was the problem?

If the browser support Image Capture API natively then it has ImageCapture in window, if the browser doesn't support Image Capture API natively then it has no ImageCapture in window.

What is this polyfill?

This polyfill is ES Module that compiled via Babel to UMD module and published to NPM.

How users install (use) this polyfill?

<script src="https://unpkg.com/[email protected]/lib/imagecapture.js"></script>

What happens after that?

Since the browser don't support Image Capture API natively, it has no ImageCapture in window. We need add (overwrite) ImageCapture in window by our UMD module (automatically export it to window). But this didn't happen and polyfill doesn't work. :-(

I've fixed it 9b27bfd. But I'm not sure if this is the right way? Isn't this a hack? Maybe is there a more elegant way to export (add) ImageCapture to window e.g. by changing Babel UMD global config?

[FluorescentHallucinogen]

BTW, please don't use https://imagecapture.js.org to reproduce this problem, because this demo is compiled by Webpack and don't use window.ImageCapture at all.

[FluorescentHallucinogen]

See https://github.com/GoogleChromeLabs/imagecapture-polyfill/blob/master/docs/bundle.js#L321

[FluorescentHallucinogen]

And compare with https://github.com/GoogleChromeLabs/imagecapture-polyfill/blob/master/docs/index.js#L74