Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for notes #15

Open
ToeBee opened this issue Apr 17, 2015 · 2 comments
Open

Add support for notes #15

ToeBee opened this issue Apr 17, 2015 · 2 comments

Comments

@ToeBee
Copy link

ToeBee commented Apr 17, 2015

Since support for notes is now in JOSM core, this plugin could support them as well. If I am seeing things correctly, the NoteData class in core will need to implement the Data interface so that it can deal with bounds. Anything else I should know?

@Gnonthgol
Copy link
Owner

When I added support for GPX I knew that notes were on the way. If you are able to get the bounds already downloaded somehow it is just to append a new if statement to DownloadStrategy.getExisting() . You may note that there is currently no common interface for the layers to give away that information so there needs to be special cases for each layer class.

@simon04
Copy link
Contributor

simon04 commented Apr 18, 2015

If you are able to get the bounds already downloaded somehow

See org.openstreetmap.josm.actions.search.SearchCompiler.InDataSourceArea for instance:

new Bounds(Main.main.getCurrentDataSet().getDataSourceArea().getBounds2D());

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants