Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(setup): Allow CE users to select their java version #37

Open
mzico opened this issue Nov 26, 2024 · 8 comments
Open

feat(setup): Allow CE users to select their java version #37

mzico opened this issue Nov 26, 2024 · 8 comments
Assignees
Labels
enhancement New feature or request

Comments

@mzico
Copy link
Contributor

mzico commented Nov 26, 2024

It would be nice if we could allow CE users to select their java version during installation just like janssen ( -java-version {11,17}]
)

@mzico mzico added the enhancement New feature or request label Nov 26, 2024
@devrimyatar
Copy link
Contributor

@yurem does all CE components run on java-11 without issues?

@devrimyatar devrimyatar transferred this issue from GluuFederation/community-edition-setup Nov 26, 2024
@moabu
Copy link
Member

moabu commented Nov 26, 2024

I don’t think allowing users to select java versions is necessary. It will create a support burden we don’t need. We are better off supporting a specific java option . In this case 17.

@yurem
Copy link
Contributor

yurem commented Nov 26, 2024

@devrimyatar I tried to upgrade jdk in already installed 4.5.5 environment. All services worked well.
I agree, one option is better. If QA will confirm that there is no issues with jdk 17 we can use it in new release.

@mzico
Copy link
Contributor Author

mzico commented Nov 26, 2024

OK, if providing option create too much issues on supporting product then let's not do it. We are going with Java 17 in 4.5.7 ( whose release date is Feb, 2025 )

@mzico mzico closed this as completed Nov 26, 2024
@mzico
Copy link
Contributor Author

mzico commented Nov 27, 2024

Quick question @yurem @devrimyatar @moabu : if we can support Java 17, why not the latest stable one... which is 23?

@mzico mzico reopened this Nov 27, 2024
@moabu
Copy link
Member

moabu commented Nov 28, 2024

If we can handle it without regression I think it would be fine. The main issue is with what needs to be changed in terms of code to allow for us to run with 23. Its a trade off that would make more sense for jans vs gluu4.

@mzico
Copy link
Contributor Author

mzico commented Dec 6, 2024

@yurem : any help on last question?

@yurem
Copy link
Contributor

yurem commented Dec 9, 2024

@mzico I agree with @moabu about using version 17
23 version requires code changes. And latest one no mean stable one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants