Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

package.json - update node engines #410

Closed
wants to merge 6 commits into from
Closed

package.json - update node engines #410

wants to merge 6 commits into from

Conversation

kdhttps
Copy link
Contributor

@kdhttps kdhttps commented Jan 18, 2022

close #407

@kdhttps kdhttps self-assigned this Jan 18, 2022
@codecov
Copy link

codecov bot commented Jan 18, 2022 •
edited
Loading

Codecov Report

Merging #410 (de99b88) into master (09221af) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #410   +/-   ##
=======================================
  Coverage   78.58%   78.58%           
=======================================
  Files          36       36           
  Lines         780      780           
=======================================
  Hits          613      613           
  Misses        167      167

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 09221af...de99b88. Read the comment docs.

@kdhttps kdhttps requested review from christian-hawk and removed request for christian-hawk January 19, 2022 07:47
@sonarcloud
Copy link

sonarcloud bot commented Jan 19, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

christian-hawk
christian-hawk suggested changes Mar 21, 2022
View reviewed changes
package.json Outdated
@@ -10,7 +10,7 @@
]
},
"engines": {
"node": ">=12.19.0 <=16.13.0"
"node": "^12.19.0 || ^14.15.0 || ^16.13.0"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as https://github.com/GluuFederation/gluu-passport/pull/397/files#r785360818 I thought we were gonna move to 16 only. Why do we still need 12 and 14?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No mate, Our passport supports 14 and 16 both. I will remove 12.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done! @christian-hawk mate, do you also want me to update the github workflows?

@sonarcloud
Copy link

sonarcloud bot commented Mar 21, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@kdhttps kdhttps requested a review from christian-hawk March 22, 2022 13:24
@kdhttps
Copy link
Contributor Author

kdhttps commented Mar 31, 2022

run tests

@christian-hawk
Copy link
Contributor

surpassed by #451

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christian-hawk christian-hawk Awaiting requested review from christian-hawk

Assignees

@kdhttps kdhttps

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

update node engines in package.json as per openid-client 5.1.1 requirements
2 participants
@kdhttps @christian-hawk