Approving PRs #106
-
|
What is the process for doing this in GliderTools? We have a PR template, but I'm unsure what the mechanism is for approving PRs. Who can approve a PR? How do we manage PR review assignment? |
Beta Was this translation helpful? Give feedback.
Replies: 2 comments 3 replies
-
|
Hi @callumrollo maybe you could link the PR template in your text? |
Beta Was this translation helpful? Give feedback.
-
|
Done, my question is more about what happens after the PR is submitted though |
Beta Was this translation helpful? Give feedback.
-
|
Sure got it. Just could not find the pull request (PR) template! Merci! |
Beta Was this translation helpful? Give feedback.
-
|
Hi @callumrollo, Currently the settings are configured that a PR requires an approving review at the minimum and then any of the admins (e.g. @lukegre @dhruvbalwada me) can merge it. Once we have a solid test base we can perhaps expand the admins, but the test really are crucial so that any admin can trust that the package will work. Ultimately I think any PR that is not a very small change should be reviewed by someone with experience on the code. This slows the process but IMO always leads to better quality code in the end. Does that answer your question? Also very happy for suggestions. I just modified these settings ad-Hof and we can modify them again. |
Beta Was this translation helpful? Give feedback.
-
|
Thanks @jbusecke, that clarifies it. Good to keep the review process. I'll focus on getting a good set of tests operational before working on the other issues |
Beta Was this translation helpful? Give feedback.
Hi @callumrollo,
Currently the settings are configured that a PR requires an approving review at the minimum and then any of the admins (e.g. @lukegre @dhruvbalwada me) can merge it.
Once we have a solid test base we can perhaps expand the admins, but the test really are crucial so that any admin can trust that the package will work.
Ultimately I think any PR that is not a very small change should be reviewed by someone with experience on the code. This slows the process but IMO always leads to better quality code in the end.
Does that answer your question? Also very happy for suggestions. I just modified these settings ad-Hof and we can modify them again.