-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Port to v0.18 #145
Comments
Waiting for rgrempel/elm-route-url#13 (comment) |
I would love to see this ported to v0.17. Looks like a great learning resource! |
Indeed, just missing some time. Hopefully will get it going soon with other Gizra devs. |
I'm working on this. elm-route-url already supports 0.17 and there are no more blocking dependencies. @amitaibu, if you give me access to the repo I will push a new branch with my current changes so anyone else can contribute. |
There are some packages that were not being handled using the elm package manager, instead they are directly on a vendor folder. One of them at least, is not going to be upgraded to 0.17: rgrempel/elm-web-api#17 I'm investigating if this vendor is really necessary or if we can get rid of it. |
Only Location seems to be used, so that should be easy. I found two modules that are using it: |
@DavidHernandez did you have any progress? I would love to see a port to 0.17! |
Not really, and I actually lost some of the progress as my laptop was stolen :( I will try to allocate some time during the next few weeks to work on this. |
I'm starting to work on this again. Following the original proposal from @amitaibu, I've removed everything I will start from the begining. All the work will be done on the same PR, on this branch from my fork: https://github.com/DavidHernandez/elm-hedley/tree/0.17-upgrade I will go replicating each of the existing pages. I already started with the login. If anyone wants to help, just fork my repo and do PRs. |
👍 |
As 0.18 has been released, so we will go directly for the 0.18 upgrade. |
@DavidHernandez What's the status on this ? Do you need any help ? |
@Nader77 right now there is only one vendor library left with no support for elm 0.18 and it is https://github.com/rgrempel/elm-route-url I will open an issue on that repository about upgrading to 0.18. |
There's already a PR for that -- rgrempel/elm-route-url#19 |
By the way, to work with different versions of Elm, there is this npm module that does a nice job: https://www.npmjs.com/package/elm-version-manager |
No description provided.
The text was updated successfully, but these errors were encountered: