Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port to v0.18 #145

Open
amitaibu opened this issue May 11, 2016 · 15 comments
Open

Port to v0.18 #145

amitaibu opened this issue May 11, 2016 · 15 comments
Assignees

Comments

@amitaibu
Copy link
Member

No description provided.

@amitaibu amitaibu self-assigned this Jun 7, 2016
@amitaibu
Copy link
Member Author

amitaibu commented Jun 7, 2016

Waiting for rgrempel/elm-route-url#13 (comment)

@michallepicki
Copy link

I would love to see this ported to v0.17. Looks like a great learning resource!

@amitaibu
Copy link
Member Author

Indeed, just missing some time. Hopefully will get it going soon with other Gizra devs.

@DavidHernandez
Copy link

I'm working on this. elm-route-url already supports 0.17 and there are no more blocking dependencies.

@amitaibu, if you give me access to the repo I will push a new branch with my current changes so anyone else can contribute.

@DavidHernandez
Copy link

There are some packages that were not being handled using the elm package manager, instead they are directly on a vendor folder. One of them at least, is not going to be upgraded to 0.17: rgrempel/elm-web-api#17

I'm investigating if this vendor is really necessary or if we can get rid of it.

@michallepicki
Copy link

Only Location seems to be used, so that should be easy. I found two modules that are using it:
Config/Update.elm and Pages/GithubAuth/Update.elm

@lisardo
Copy link

lisardo commented Nov 4, 2016

@DavidHernandez did you have any progress? I would love to see a port to 0.17!

@DavidHernandez
Copy link

Not really, and I actually lost some of the progress as my laptop was stolen :(

I will try to allocate some time during the next few weeks to work on this.

@DavidHernandez
Copy link

I'm starting to work on this again. Following the original proposal from @amitaibu, I've removed everything I will start from the begining. All the work will be done on the same PR, on this branch from my fork: https://github.com/DavidHernandez/elm-hedley/tree/0.17-upgrade

I will go replicating each of the existing pages. I already started with the login. If anyone wants to help, just fork my repo and do PRs.

@amitaibu
Copy link
Member Author

amitaibu commented Nov 9, 2016

👍

@DavidHernandez DavidHernandez changed the title Port to v0.17 Port to v0.18 Nov 15, 2016
@DavidHernandez
Copy link

As 0.18 has been released, so we will go directly for the 0.18 upgrade.

@nedSaf
Copy link

nedSaf commented Nov 24, 2016

@DavidHernandez What's the status on this ? Do you need any help ?

@DavidHernandez
Copy link

@Nader77 right now there is only one vendor library left with no support for elm 0.18 and it is https://github.com/rgrempel/elm-route-url

I will open an issue on that repository about upgrading to 0.18.

@amitaibu
Copy link
Member Author

There's already a PR for that -- rgrempel/elm-route-url#19

@DavidHernandez
Copy link

By the way, to work with different versions of Elm, there is this npm module that does a nice job: https://www.npmjs.com/package/elm-version-manager

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants