Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REMINDER] Notes + some tiny typos #12

Open
GiorgosXou opened this issue Feb 26, 2022 · 10 comments
Open

[REMINDER] Notes + some tiny typos #12

GiorgosXou opened this issue Feb 26, 2022 · 10 comments

Comments

@GiorgosXou
Copy link
Owner

#define NumberOf(arg) ((unsigned int) (sizeof (arg) / sizeof (arg [0]))) // calculates the number of layers (in this case 4)

*calculates the number of "elements in an array" not "layers"

@GiorgosXou

This comment was marked as resolved.

@GiorgosXou

This comment was marked as resolved.

@GiorgosXou GiorgosXou changed the title A tiny mistake Some tiny typos May 21, 2022
@GiorgosXou GiorgosXou changed the title Some tiny typos Notes + some tiny typos Nov 30, 2023
@GiorgosXou GiorgosXou changed the title Notes + some tiny typos [REMINDER] Notes + some tiny typos Nov 30, 2023
@GiorgosXou
Copy link
Owner Author

@GiorgosXou

This comment was marked as resolved.

@GiorgosXou

This comment was marked as resolved.

@GiorgosXou

This comment was marked as resolved.

@GiorgosXou
Copy link
Owner Author

This softmax part-implementation for use with any ACTIVATION__PER_LAYER, (even thought I trust myself, not gonna lie) seems slightly suspicious:

void NeuralNetwork::Layer::Softmax() {for (int i = 0; i < _numberOfOutputs; i++){outputs[i] /= me->sumOfSoftmax;}}

And by suspicious, I mean: i don't remember 😭 + division lol

@GiorgosXou
Copy link
Owner Author

Reminder: Remove space in middle after = :

layers[i].weights[j][k] = *((DFLOAT*)(&tmp)); // toFloat() which is atof() is not accurate (at least on Arduino UNO)

@GiorgosXou

This comment was marked as resolved.

@GiorgosXou

This comment was marked as resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant